Bug 1848687: Fix router metrics to be accurate in 4.4 #25165
Conversation
The new metrics backend exposed metrics were explicitly checked to not return - we will weaken that test in anticipation of the other PR being merged.
openshift-ci-robot
added
bugzilla/severity-medium
|
@smarterclayton: This pull request references Bugzilla bug 1848687, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
This is a partial backport of the max_sessions test, but because this is a backported fix that won't work until changes land in another repo, the test is disabled.
smarterclayton
force-pushed
the
metrics_test
branch
from
ff1f74e
to
9b751aa
Compare
|
/assign @frobware |
|
@smarterclayton: This pull request references Bugzilla bug 1848687, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
shawn-hurley
added
the
cherry-pick-approved
|
@smarterclayton: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The changes to reporting router backend metrics requires a change to our tests to allow backend metrics to be reported, as well as a fix for a flake in the tests after the fix is delivered. The max_sessions test is disabled because it requires the code to be delivered first and we don't want to do this in two rounds of delivery. We are confident the code works in the latest release.