Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix #25173

Merged
merged 2 commits into from Jun 24, 2020
Merged

[release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix #25173

merged 2 commits into from Jun 24, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #25140

/assign rphillips

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1831908 has been cloned as Bugzilla bug 1849269. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix

In response to this:

[release-4.5] Bug 1831908: bump cadvisor for incorrect diskstats fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 20, 2020
@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1831908: bump cadvisor for incorrect diskstats fix [release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix Jun 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 20, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1849269, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1831908 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1831908 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

[release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 20, 2020
@nee1esh
Copy link

nee1esh commented Jun 22, 2020

/retest

@mrunalp mrunalp added staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 22, 2020
@sjenning
Copy link
Contributor

/override ci/prow/e2e-aws-disruptive

@sjenning
Copy link
Contributor

e2e-vsphere isn't completely busted... but is mostly busted https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/?job=pull-ci-openshift-origin-release-4.5-e2e-vsphere

@openshift-ci-robot
Copy link

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-disruptive

In response to this:

/override ci/prow/e2e-aws-disruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

/test e2e-vsphere

@smarterclayton
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Jun 23, 2020

/override e2e-vsphere

@openshift-ci-robot
Copy link

@bparees: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-vsphere

Only the following contexts were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-disruptive
  • ci/prow/e2e-aws-image-registry
  • ci/prow/e2e-aws-jenkins
  • ci/prow/e2e-aws-serial
  • ci/prow/e2e-azure
  • ci/prow/e2e-cmd
  • ci/prow/e2e-conformance-k8s
  • ci/prow/e2e-gcp
  • ci/prow/e2e-gcp-builds
  • ci/prow/e2e-gcp-image-ecosystem
  • ci/prow/e2e-gcp-upgrade
  • ci/prow/e2e-vsphere
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • tide

In response to this:

/override e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor

bparees commented Jun 23, 2020

/override ci/prow/e2e-vsphere

@openshift-ci-robot
Copy link

@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-vsphere

In response to this:

/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere c0373bd link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 77c9a6a into openshift:release-4.5 Jun 24, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/origin#25173. Bugzilla bug 1849269 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1849269: bump cadvisor for incorrect diskstats fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Contributor

harche commented Jul 13, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link
Author

@harche: #25173 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	glide.lock
M	glide.yaml
Falling back to patching base and 3-way merge...
Auto-merging glide.yaml
CONFLICT (content): Merge conflict in glide.yaml
Auto-merging glide.lock
Patch failed at 0001 deps: bump cadvisor to fix incorrect diskstats on mapper devices

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning sjenning mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@rphillips rphillips

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet