Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1860832: Ensure Azure availability zone is always in lower cases #25327

Merged
merged 1 commit into from Aug 15, 2020
Merged

Bug 1860832: Ensure Azure availability zone is always in lower cases #25327

merged 1 commit into from Aug 15, 2020

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Jul 27, 2020

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 27, 2020
@openshift-ci-robot
Copy link

@enxebre: This pull request references Bugzilla bug 1860832, which is invalid:

  • expected dependent Bugzilla bug 1860128 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1860829 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1860830 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1860128 to target a release in 4.4.0, 4.4.z, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1860829 to target a release in 4.4.0, 4.4.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1860832: Ensure Azure availability zone is always in lower cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 27, 2020
@ehashman ehashman mentioned this pull request Jul 27, 2020
Closed
ehashman
ehashman approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@mjudeikis: This pull request references Bugzilla bug 1860832, which is invalid:

  • expected dependent Bugzilla bug 1860830 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1860128 to target a release in 4.4.0, 4.4.z, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1860829 to target a release in 4.4.0, 4.4.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member Author

enxebre commented Aug 6, 2020

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1860832, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1860830 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1860830 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 10, 2020
@JoelSpeed
Copy link
Contributor

/retest

4 similar comments
@mjudeikis
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/lgtm
/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@eparis
Copy link
Member

eparis commented Aug 11, 2020

/approve
because joel indicated he needed someone to take a look

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, enxebre, eparis, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@ehashman
Copy link
Contributor

@eparis can you or someone else approve the cherry-pick?

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 13, 2020
@sferich888
Copy link
Contributor

/retest tide

@openshift-ci-robot
Copy link

@sferich888: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-conformance-k8s
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test images-artifacts
  • /test unit
  • /test verify

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-release-4.3-e2e-aws-serial
  • pull-ci-openshift-origin-release-4.3-e2e-cmd
  • pull-ci-openshift-origin-release-4.3-e2e-gcp
  • pull-ci-openshift-origin-release-4.3-e2e-gcp-upgrade
  • pull-ci-openshift-origin-release-4.3-images
  • pull-ci-openshift-origin-release-4.3-images-artifacts
  • pull-ci-openshift-origin-release-4.3-unit
  • pull-ci-openshift-origin-release-4.3-verify

In response to this:

/retest tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cuppett
Copy link
Member

cuppett commented Aug 13, 2020

/retest

4 similar comments
@sferich888
Copy link
Contributor

/retest

@JoelSpeed
Copy link
Contributor

/retest

@cuppett
Copy link
Member

cuppett commented Aug 14, 2020

/retest

@sferich888
Copy link
Contributor

/retest

@cuppett
Copy link
Member

cuppett commented Aug 14, 2020

/test e2e-gcp

@eparis
Copy link
Member

eparis commented Aug 14, 2020

/retest

2 similar comments
@cuppett
Copy link
Member

cuppett commented Aug 14, 2020

/retest

@cuppett
Copy link
Member

cuppett commented Aug 14, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cuppett
Copy link
Member

cuppett commented Aug 14, 2020

/retest

1 similar comment
@cuppett
Copy link
Member

cuppett commented Aug 15, 2020

/retest

@eparis
Copy link
Member

eparis commented Aug 15, 2020

/override ci/prow/e2e-gcp
/override ci/prow/e2e-cmd
/override ci/prow/e2e-aws-serial

@eparis
Copy link
Member

eparis commented Aug 15, 2020

e2e-gcp-gather-extra, after the ci test, appears to fail, not the testin itself...

@openshift-ci-robot
Copy link

@eparis: Overrode contexts on behalf of eparis: ci/prow/e2e-aws-serial, ci/prow/e2e-cmd, ci/prow/e2e-gcp

In response to this:

/override ci/prow/e2e-gcp
/override ci/prow/e2e-cmd
/override ci/prow/e2e-aws-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Aug 15, 2020

If the batch fails, i'll merge by hand in the morning.

@openshift-merge-robot openshift-merge-robot merged commit 870e190 into openshift:release-4.3 Aug 15, 2020
@openshift-ci-robot
Copy link

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25327. Bugzilla bug 1860832 has been moved to the MODIFIED state.

In response to this:

Bug 1860832: Ensure Azure availability zone is always in lower cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman approved these changes

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@derekwaynecarr derekwaynecarr

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet