Bug 1867800: Make EBS attachDisk idempotent #25400

gnufied · 2020-08-10T19:34:23Z

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1867800

@openshift/sig-storage

openshift-ci-robot · 2020-08-10T19:34:27Z

@gnufied: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2020-08-18T15:17:51Z

/retest

huffmanca · 2020-08-18T15:22:46Z

/lgtm

openshift-bot · 2020-08-19T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-19T01:01:00Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-20T01:00:48Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-20T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-21T01:01:00Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-21T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-22T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-22T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-23T01:00:56Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-23T01:00:59Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-24T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-24T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-25T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-25T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-08-26T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-08-26T01:00:50Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-20T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-20T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-21T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-21T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-22T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-22T01:01:23Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-23T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-23T01:00:44Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-24T01:00:35Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-09-24T01:00:40Z

@openshift-bot: This pull request references Bugzilla bug 1867800, which is invalid:

expected dependent Bugzilla bug 1866843 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2020-09-24T15:36:39Z

/bugzilla-refresh

gnufied · 2020-09-24T15:36:52Z

/bugzilla refresh
/retest

openshift-ci-robot · 2020-09-24T15:36:59Z

@gnufied: This pull request references Bugzilla bug 1867800, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1866843 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1866843 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnufied · 2020-09-25T15:33:09Z

/retest

gnufied · 2020-09-30T15:14:13Z

/retest

ashcrow · 2020-10-01T14:16:18Z

@gnufied I don't see a PR in the main branch for this. Is it safe to say that the change will still be applied but via kubernetes rebases?

gnufied · 2020-10-01T14:22:03Z

@ashcrow yes the change to master was brought via k/k rebase of 1.19. See - https://github.com/openshift/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/aws/aws.go#L262

Also we did had a blocker bug for 4.6 which is already verified and passed QE - https://bugzilla.redhat.com/show_bug.cgi?id=1866843

ashcrow · 2020-10-05T17:29:40Z

Note to next patch manager: Label removed due to missing approved.

knobunc · 2020-10-06T00:48:00Z

/approve

openshift-ci-robot · 2020-10-06T00:51:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, huffmanca, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-10-06T00:55:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-06T02:26:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-07T14:21:07Z

@gnufied: All pull requests linked via external trackers have merged:

openshift/origin#25400

Bugzilla bug 1867800 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the sig/storage label Aug 10, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 10, 2020

openshift-ci-robot requested review from smarterclayton and tbielawa August 10, 2020 19:34

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Aug 10, 2020

UPSTREAM: 93865: Make EBS attach disk idempotent

94cb946

gnufied force-pushed the fix-ebs-attach-idempotent branch from d3c1254 to 94cb946 Compare August 17, 2020 22:18

Update generated test annotations

499b90d

openshift-ci-robot assigned huffmanca Aug 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 24, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 24, 2020

ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 1, 2020

ashcrow removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 5, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 7, 2020

openshift-merge-robot merged commit f0e3661 into openshift:release-4.5 Oct 7, 2020

Bug 1867800: Make EBS attachDisk idempotent #25400

Bug 1867800: Make EBS attachDisk idempotent #25400

Conversation

gnufied commented Aug 10, 2020

openshift-ci-robot commented Aug 10, 2020

gnufied commented Aug 18, 2020

huffmanca commented Aug 18, 2020

openshift-bot commented Aug 19, 2020

openshift-ci-robot commented Aug 19, 2020

openshift-bot commented Aug 20, 2020

openshift-ci-robot commented Aug 20, 2020

openshift-bot commented Aug 21, 2020

openshift-ci-robot commented Aug 21, 2020

openshift-bot commented Aug 22, 2020

openshift-ci-robot commented Aug 22, 2020

openshift-bot commented Aug 23, 2020

openshift-ci-robot commented Aug 23, 2020

openshift-bot commented Aug 24, 2020

openshift-ci-robot commented Aug 24, 2020

openshift-bot commented Aug 25, 2020

openshift-ci-robot commented Aug 25, 2020

openshift-bot commented Aug 26, 2020

openshift-ci-robot commented Aug 26, 2020

openshift-bot commented Sep 20, 2020

openshift-ci-robot commented Sep 20, 2020

openshift-bot commented Sep 21, 2020

openshift-ci-robot commented Sep 21, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-bot commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

gnufied commented Sep 24, 2020

gnufied commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

gnufied commented Sep 25, 2020

gnufied commented Sep 30, 2020

ashcrow commented Oct 1, 2020

gnufied commented Oct 1, 2020 • edited

ashcrow commented Oct 5, 2020

knobunc commented Oct 6, 2020

openshift-ci-robot commented Oct 6, 2020

openshift-bot commented Oct 6, 2020

openshift-bot commented Oct 6, 2020

openshift-ci-robot commented Oct 7, 2020

gnufied commented Oct 1, 2020 •

edited