Bug 1906588: normalize ginkgo structuring so we avoid timing windows with k8s e2e setup when changing user #25754
Conversation
openshift-ci-robot
added
do-not-merge/hold
gabemontero
force-pushed
the
dbg-e2e-gcp-builds
branch
from
07adf2b
to
05bf336
Compare
gabemontero
changed the title
openshift-ci-robot
added
bugzilla/severity-urgent
|
@gabemontero: This pull request references Bugzilla bug 1906588, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
gabemontero
changed the title
|
and we have a passing e2e-gcp-builds again !! I'll update the other pipelines (for the jenkins repo and for s390 / ppc64le) and let's get his reviewed for tag / merge @akram @waveywaves - FYI ... it looks like recent changes in k8s e2e framework has exposed some timing windows in the pipeline strategy tests with how we structured the g.Describe, g.Context, etc., which we had done to minimize the number of concurrent jenkins instances. That is no longer tenable, and I've changed the ginkgo embedding to match what we do in the other e2e's. @petr-muller @stevekuznetsov @soltysh @adambkaplan @coreydaley @otaviof |
gabemontero
force-pushed
the
dbg-e2e-gcp-builds
branch
from
05bf336
to
2eed1c4
Compare
|
/hold cancel /assign @adambkaplan but feel free to lgtm if you get anxious @soltysh ;-) review will be easiest if you use the https://github.com/openshift/origin/pull/25754/files?w=1 to eliminate white space diffs |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
1 similar comment
|
/retest |
…s with k8s e2e setup logic (and hope memory is OK)
gabemontero
force-pushed
the
dbg-e2e-gcp-builds
branch
from
2eed1c4
to
db28cbd
Compare
|
string stutter addressed @adambkaplan PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/override ci/prow/e2e-agnostic-cmd |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
thanks @soltysh was going to ask for that when I came back from lunch otherwise, fips has passed previously and this PRs changes do not impact it ... so hopefully its flakes are not persistent and we finish with this one |
|
sigh ... sig-api-machinery and sig-network failures in fips still /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@gabemontero: All pull requests linked via external trackers have merged: Bugzilla bug 1906588 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold
/test e2e-gcp-builds