New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update images README and add OWNERS #25769
test: Update images README and add OWNERS #25769
Conversation
1637b76
to
9236dc8
Compare
Can we get some documentation that explains what this process actually does? Things i'm confused about:
I also put some questions in https://github.com/openshift/origin/pull/24887/files#r538841935 that could use clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Document the review criteria as part of accepting rebase.
9236dc8
to
20dc4ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -17,7 +17,11 @@ for easy mirroring by the `openshift-tests images` command. | |||
* Describe your use case in a PR to this file and have it approved | |||
* Define a standard CI build and publish the image to quay.io in the openshift namespace | |||
* Add the new reference to the `init()` method in this package | |||
* Have the automation promote the image to the quay mirror location. | |||
* Reference your image inside your tests tests using `github.com/openshift/origin/test/extended/util/image.LocationFor("my.source/image/location:versioned_tag")` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Reference your image inside your tests tests using `github.com/openshift/origin/test/extended/util/image.LocationFor("my.source/image/location:versioned_tag")` | |
* Reference your image inside your tests using `github.com/openshift/origin/test/extended/util/image.LocationFor("my.source/image/location:versioned_tag")` |
@@ -17,7 +17,11 @@ for easy mirroring by the `openshift-tests images` command. | |||
* Describe your use case in a PR to this file and have it approved | |||
* Define a standard CI build and publish the image to quay.io in the openshift namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To the best of my understanding CI builds don't push to quay.io nor to the openshift namespace, so i'm confused by this.
CI builds push to registry.svc.ci.openshift.org and generally in the ocp namespace (though certainly they can push to other namespaces)
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Document the review criteria as part of accepting rebase.