Bug 1916419: broaden acceptance of scl sample s2i image usage messages #25799

gabemontero · 2021-01-14T18:26:11Z

/assign @bparees
in Adam's absence

@pedjak @jasperchui FYI per our discussion today I got a couple of cycles so I went ahead and threw this up

So the SCL folks recently tweaked the s2i usage message for 2 of their images such that it no longer passes in the test referenced by the associated bugzilla.

That said, at least in my opinion, their usage messages seem good enough to me. I've pasted them in the associated bugzilla.

So, what to do:

for now, this PR broadens the acceptance criteria for the images; we could review and iterate and go with some form of this for the test
during my discussion with @pedjak he brought up a point I'm sure has come up with us before @bparees .... string verifications like this are fragile; agreed - but conversely, I think making sure they have some sensible usage message is warranted, and in the past at least, that side of the argument as won out .... should that continue
also during our discussion, @pedjak asked another good question: do we proscribe somewhere for sample providers requirements for s2i based images' usage messages that the supply to OCP .... I could not recall any at the time. And looking after the fact, the closest I found was https://github.com/openshift/source-to-image#anatomy-of-a-builder-image where it says the usage script is optional. Unless you know otherwise, my initial thought in response was we should minimally add some verbiage in the openshift/library readme about what should be there if you supply a usage script for s2i. And since it is optional, maybe that is argument against verifying the message for the SCL images in the first place.

Thoughts?

openshift-ci-robot · 2021-01-14T18:26:15Z

@gabemontero: This pull request references Bugzilla bug 1916419, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1916419: broaden acceptance of scl sample s2i image usage messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-01-14T18:26:58Z

/bugzilla refresh

openshift-ci-robot · 2021-01-14T18:27:03Z

@gabemontero: An error was encountered adding this pull request to the external tracker bugs for bug 1916419 on the Bugzilla server at https://bugzilla.redhat.com. We were able to detect the following conditions from the error:

The Bugzilla server failed to load data from GitHub when creating the bug. This is usually caused by rate-limiting, please try again later.

Full error message.


JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/origin/pulls/25799 Error: 403 Forbidden at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559589...', 'https://api.github.com/repos/openshift/origin/pulls/25799', 'GET') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559589...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559589053670)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559589053670)', 1) called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595895a9290)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595887d5208)', 'HASH(0x559589ca2080)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x559589ca2080)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559588740b20)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595888ff070)') called at (eval 4094) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587548070)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587548070)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586d1b468)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559588ab8750)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559588ab8750)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d1b468)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d1b468)') called at (eval 4094) line 0 eval {...} called at (eval 4094) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x559586df8938)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x559586df8938)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559589...', 'https://api.github.com/repos/openshift/origin/pulls/25799', 'GET') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559589...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559589053670)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559589053670)', 1) called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5595895a9290)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595887d5208)', 'HASH(0x559589ca2080)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x559589ca2080)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559588740b20)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595888ff070)') called at (eval 4094) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587548070)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587548070)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559586d1b468)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x559588ab8750)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x559588ab8750)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d1b468)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559586d1b468)') called at (eval 4094) line 0 eval {...} called at (eval 4094) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-01-14T18:32:58Z

/bugzilla refresh

openshift-ci-robot · 2021-01-14T18:33:02Z

@gabemontero: An error was encountered adding this pull request to the external tracker bugs for bug 1916419 on the Bugzilla server at https://bugzilla.redhat.com. We were able to detect the following conditions from the error:

The Bugzilla server failed to load data from GitHub when creating the bug. This is usually caused by rate-limiting, please try again later.

Full error message.


JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/origin/pulls/25799 Error: 403 Forbidden at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559588...', 'https://api.github.com/repos/openshift/origin/pulls/25799', 'GET') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559588...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586ced868)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586ced868)', 1) called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559588bfbc38)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958750ced8)', 'HASH(0x55958750d310)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958750d310)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559588ddce38)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587805670)') called at (eval 3955) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595894c5a20)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595894c5a20)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559588108450)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595898ff5b0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595898ff5b0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559588108450)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559588108450)') called at (eval 3955) line 0 eval {...} called at (eval 3955) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x559588c73ec8)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x559588c73ec8)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559588...', 'https://api.github.com/repos/openshift/origin/pulls/25799', 'GET') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559588...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586ced868)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559586ced868)', 1) called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559588bfbc38)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55958750ced8)', 'HASH(0x55958750d310)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55958750d310)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x559588ddce38)') called at /loader/0x5595832975d0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559587805670)') called at (eval 3955) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595894c5a20)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595894c5a20)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559588108450)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595898ff5b0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5595898ff5b0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559588108450)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559588108450)') called at (eval 3955) line 0 eval {...} called at (eval 3955) line 0

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2021-01-14T18:44:19Z

/lgtm

openshift-ci-robot · 2021-01-14T18:44:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-01-14T20:43:03Z

@gabemontero: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-cmd	`290e2a9`	link	`/test e2e-agnostic-cmd`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gabemontero · 2021-01-14T22:49:19Z

image eco passed ... all that is needed for this PR

/skip

gabemontero · 2021-01-14T22:49:28Z

/retest

gabemontero · 2021-01-14T23:23:25Z

/bugzilla refresh

openshift-ci-robot · 2021-01-14T23:23:31Z

@gabemontero: This pull request references Bugzilla bug 1916419, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-15T04:04:36Z

@gabemontero: All pull requests linked via external trackers have merged:

openshift/origin#25799

Bugzilla bug 1916419 has been moved to the MODIFIED state.

In response to this:

Bug 1916419: broaden acceptance of scl sample s2i image usage messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-01-15T12:41:22Z

/cherrypick release-4.6

openshift-cherrypick-robot · 2021-01-15T12:49:19Z

@gabemontero: new pull request created: #25804

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

broaden acceptance of scl sample s2i image usage messages

290e2a9

openshift-ci-robot assigned bparees Jan 14, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 14, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 14, 2021

openshift-ci-robot requested review from adambkaplan and smarterclayton January 14, 2021 18:29

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 14, 2021

openshift-merge-robot merged commit cfa30d6 into openshift:master Jan 15, 2021

gabemontero deleted the scl-usage-msg branch January 15, 2021 12:40

openshift-cherrypick-robot mentioned this pull request Jan 15, 2021

[release-4.6] Bug 1916687: broaden acceptance of scl sample s2i image usage messages #25804

Merged

gabemontero mentioned this pull request Jan 21, 2021

Bug 1889954: bump(*) to mitigate CVE-2020-8564 openshift/builder#195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1916419: broaden acceptance of scl sample s2i image usage messages #25799

Bug 1916419: broaden acceptance of scl sample s2i image usage messages #25799

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

bparees commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

openshift-ci bot commented Jan 14, 2021 •

edited

gabemontero commented Jan 14, 2021

gabemontero commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

openshift-ci-robot commented Jan 15, 2021

gabemontero commented Jan 15, 2021

openshift-cherrypick-robot commented Jan 15, 2021

Bug 1916419: broaden acceptance of scl sample s2i image usage messages #25799

Bug 1916419: broaden acceptance of scl sample s2i image usage messages #25799

Conversation

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

bparees commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

openshift-ci bot commented Jan 14, 2021 • edited

gabemontero commented Jan 14, 2021

gabemontero commented Jan 14, 2021

gabemontero commented Jan 14, 2021

openshift-ci-robot commented Jan 14, 2021

openshift-ci-robot commented Jan 15, 2021

gabemontero commented Jan 15, 2021

openshift-cherrypick-robot commented Jan 15, 2021

openshift-ci bot commented Jan 14, 2021 •

edited