Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1902054: Update multicast test image for use in release-4.6 #25825

Merged
merged 1 commit into from Feb 12, 2021

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Jan 25, 2021

In order to get around docker rate limiting, the e2e tests
need to pull images off either quay or the local image
registry. This change updates the multicast image to be
pulled from the local image registry.

Signed-off-by: Aniket Bhat anbhat@redhat.com

@openshift-ci-robot
Copy link

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Update multicast test image for use in release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2021
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@abhat
Copy link
Contributor Author

abhat commented Jan 25, 2021

/test ci/prow/e2e-vsphere-upi

@openshift-ci-robot
Copy link

@abhat: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-release-4.6-e2e-agnostic-cmd
  • pull-ci-openshift-origin-release-4.6-e2e-aws
  • pull-ci-openshift-origin-release-4.6-e2e-aws-csi
  • pull-ci-openshift-origin-release-4.6-e2e-aws-fips
  • pull-ci-openshift-origin-release-4.6-e2e-aws-serial
  • pull-ci-openshift-origin-release-4.6-e2e-aws-upgrade
  • pull-ci-openshift-origin-release-4.6-e2e-gcp
  • pull-ci-openshift-origin-release-4.6-e2e-gcp-upgrade
  • pull-ci-openshift-origin-release-4.6-images
  • pull-ci-openshift-origin-release-4.6-verify
  • pull-ci-openshift-origin-release-4.6-verify-deps

In response to this:

/test ci/prow/e2e-vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Jan 25, 2021

/test e2e-vsphere-upi

@openshift-ci-robot
Copy link

@abhat: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test verify
  • /test verify-deps

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-release-4.6-e2e-agnostic-cmd
  • pull-ci-openshift-origin-release-4.6-e2e-aws
  • pull-ci-openshift-origin-release-4.6-e2e-aws-csi
  • pull-ci-openshift-origin-release-4.6-e2e-aws-fips
  • pull-ci-openshift-origin-release-4.6-e2e-aws-serial
  • pull-ci-openshift-origin-release-4.6-e2e-aws-upgrade
  • pull-ci-openshift-origin-release-4.6-e2e-gcp
  • pull-ci-openshift-origin-release-4.6-e2e-gcp-upgrade
  • pull-ci-openshift-origin-release-4.6-images
  • pull-ci-openshift-origin-release-4.6-verify
  • pull-ci-openshift-origin-release-4.6-verify-deps

In response to this:

/test e2e-vsphere-upi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Jan 25, 2021

/test e2e-vsphere

@abhat
Copy link
Contributor Author

abhat commented Jan 26, 2021

/test e2e-vsphere

@abhat abhat changed the title Update multicast test image for use in release-4.6 Bug 1902054: Update multicast test image for use in release-4.6 Jan 26, 2021
@abhat abhat marked this pull request as ready for review January 26, 2021 18:13
@abhat
Copy link
Contributor Author

abhat commented Jan 26, 2021

cc @gabemontero.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 26, 2021
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1902054, which is invalid:

  • expected dependent Bugzilla bug 1902029 to target a release in 4.7.0, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1902054: Update multicast test image for use in release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 26, 2021
@abhat
Copy link
Contributor Author

abhat commented Jan 28, 2021

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2021
@openshift-ci-robot
Copy link

@abhat: This pull request references Bugzilla bug 1902054, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1901675 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1901675 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 28, 2021
@abhat
Copy link
Contributor Author

abhat commented Jan 28, 2021

/test e2e-vsphere
/test e2e-gcp

@abhat
Copy link
Contributor Author

abhat commented Jan 28, 2021

/test e2e-gcp-upgrade

test/extended/networking/multicast.go Outdated Show resolved Hide resolved
@@ -167,7 +166,7 @@ func launchTestMulticastPod(f *e2e.Framework, nodeName string, podName string) e
Containers: []kapiv1.Container{
{
Name: contName,
Image: "openshift/test-multicast",
Image: "quay.io/openshift/community-e2e-images:e2e-docker-io-openshift-test-multicast-latest-4AxcBBxKg_prX34z",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That URL seems pretty sketchy. Is that actually stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's what we have in 4.7. I couldn't find a better way to indirect other than using the whole image.LocationFor API which doesn't exist today in 4.6 at all.

In order to get around docker rate limiting, the e2e tests
need to pull images off either quay or the local image
registry. This change updates the multicast image to be
pulled from the local image registry.

Signed-off-by: Aniket Bhat <anbhat@redhat.com>
@abhat
Copy link
Contributor Author

abhat commented Feb 5, 2021

/test e2e-aws-upgrade
/test e2e-agnostic-cmd

@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 12, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2021

@abhat: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 18168e3 link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0eda899 into openshift:release-4.6 Feb 12, 2021
@openshift-ci-robot
Copy link

@abhat: All pull requests linked via external trackers have merged:

Bugzilla bug 1902054 has been moved to the MODIFIED state.

In response to this:

Bug 1902054: Update multicast test image for use in release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Mar 3, 2021

/cherry-pick release-4.5

@openshift-cherrypick-robot

@abhat: new pull request created: #25933

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants