Bug 1899941: Add e2e test for liveness override annotation #25828
Conversation
|
@ehashman: Bugzilla bug 1899941 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
(CI didn't have the updated kubelet when I pulled this morning, so I'm hoping it has it now or this test will fail across the board) |
|
/lgtm Very nice! |
|
flake https://bugzilla.redhat.com/show_bug.cgi?id=1896218 |
|
This is my first time adding an e2e -- I'm not actually seeing this test ( |
|
/retest Ryan points out that it did indeed run and pass! |
|
/lgtm |
|
/assign @smarterclayton can you PTAL? :) |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[must-gather ] OUT Get "https://api.ci-op-22ncqc7d-098b0.origin-ci-int-gce.dev.openshift.com:6443/apis/image.openshift.io/v1/namespaces/openshift/imagestreams/must-gather": dial tcp 35.231.82.14:6443: i/o timeout /retest |
|
We might just need to override this test, it's not passing for anyone. See: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-master-e2e-agnostic-cmd |
Just found that the test is not blocking for this repo. Just get approval and PR will merge. |
| g.By("creating the pod") | ||
| podName := naming.GetPodName("pod-liveness-override", string(uuid.NewUUID())) | ||
| pod := e2epod.NewAgnhostPod(f.Namespace.Name, podName, nil, nil, nil, "bash", "-c", "sleep 1000") | ||
| gracePeriod := int64(60) |
There was a problem hiding this comment.
Set the pod level much much higher so it's super obvious when it fails - 5 or 10m?
There was a problem hiding this comment.
The test will timeout after 30s but I can do that. https://github.com/openshift/origin/pull/25828/files#diff-eceac8f75c3d7d1cae6db4c354feb7a2818a29d982421378f9da3a254bdd6075R47
|
/retest |
1 similar comment
|
/retest |
|
@smarterclayton made requested changes and tests are passing, PTAL |
|
/bugzilla refresh |
|
@nee1esh: Bugzilla bug 1899941 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mrunalp
added
the
bugzilla/valid-bug
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, rphillips, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1899941
Tests openshift/kubernetes#527
Add an e2e test that verifies the liveness override annotation works.
Ran the test 103 times in a while loop on a nightly cluster to tune parameters and verify the fix.
Analyzed data on time elapsed, in seconds:
I had the timeout threshold set at 25s before but upped to 30s just to be super safe given the max...
/cc @rphillips