Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1900989: test/extended/router: add idle/unidle e2e test #25850

Merged

Conversation

frobware
Copy link
Contributor

@frobware frobware commented Feb 3, 2021

An explicit test to assert that a service that is idled will be
unidled when a GET request occurs on the route.

An explicit test to assert that a service that is idled will be
unidled when a GET request occurs on the route.
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 3, 2021
@openshift-ci-robot
Copy link

@frobware: This pull request references Bugzilla bug 1900989, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1900989: test/extended/router: add idle/unidle e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

frobware commented Feb 3, 2021

/test e2e-agnostic-cmd

@sgreene570
Copy link

/retest

@sgreene570
Copy link

/lgtm
/hold while we figure out why CI is using stale router builds

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2021
@knobunc
Copy link
Contributor

knobunc commented Feb 3, 2021

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, knobunc, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@frobware
Copy link
Contributor Author

frobware commented Feb 3, 2021

This will continue to fail in CI until we pick up the latest router commits:

From slack & @sgreene570:

Looks like the router image isn't using latest HEAD commit from the openshift/router repo. Any ideas why?
ie when I run oc adm release info --commits | grep router for 4.7.0-0.ci-2021-02-03-104157, I get the hash 25b1656, which is from Jan 20, but more commits merged on jan 28, so the current build commit should be 30e2fb5 from my understanding (See https://github.com/openshift/router/commits/master)

@frobware
Copy link
Contributor Author

frobware commented Feb 3, 2021

/cherry-pick release-4.6

@openshift-cherrypick-robot

@frobware: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e40e23e into openshift:master Feb 3, 2021
@openshift-ci-robot
Copy link

@frobware: All pull requests linked via external trackers have merged:

Bugzilla bug 1900989 has been moved to the MODIFIED state.

In response to this:

Bug 1900989: test/extended/router: add idle/unidle e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@frobware: #25850 failed to apply on top of branch "release-4.6":

Applying: test/extended/router: add e2e for idle/unidle
Applying: Update bindata
Using index info to reconstruct a base tree...
M	test/extended/testdata/bindata.go
M	test/extended/util/annotate/generated/zz_generated.annotations.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/util/annotate/generated/zz_generated.annotations.go
Auto-merging test/extended/testdata/bindata.go
CONFLICT (content): Merge conflict in test/extended/testdata/bindata.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Update bindata
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants