Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1924128: Allow RHE7 /run contents for build fs test #25854

Merged
merged 1 commit into from Feb 5, 2021
Merged

Bug 1924128: Allow RHE7 /run contents for build fs test #25854

merged 1 commit into from Feb 5, 2021

Conversation

alicerum
Copy link

@alicerum alicerum commented Feb 3, 2021

On RHEL7 workers /run contents for build fs test are different from all the other variants we are checking, which makes test fail on RHEL7 workers as seen in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1924128
Adding correct string from RHEL7 worker to the list of checked contents should help.

Allow RHE7 /run contents for build fs test
ff188a0 
On RHEL7 workers /run contents for build fs test are different
from all thore variants we are checking, which makes test fail
on RHEL7 workers. Adding correct contents to the list of checked
contents should help
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2021
@openshift-ci-robot
Copy link

@alicerum: This pull request references Bugzilla bug 1924128, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1924128: WIP - Allow RHE7 /run contents for build fs test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/assign @gabemontero

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 3, 2021
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1924128, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

@alicerum if the want the WIP label to be placed on the PR (which would prevent merging even if inadvertently tagged for merge while you are still working on it), I believe you put the WIP in the beginning of the PR text.

You also use the hold command per the list of prow commands at https://go.k8s.io/bot-commands?repo=openshift%2Forigin

@gabemontero
Copy link
Contributor

fwiw I think it is good to go, unless the e2e's find some yaml formatting issues or some such

so I'll
/hold
(I'll let you practice updating the PR title for the WIP stuff, as well as practice unholding
then
/lgtm
(which should also add approve since I'm in the OWNERS file)

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 3, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alicerum, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@alicerum alicerum changed the title Bug 1924128: WIP - Allow RHE7 /run contents for build fs test WIP - Bug 1924128: Allow RHE7 /run contents for build fs test Feb 3, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2021
@alicerum
Copy link
Author

alicerum commented Feb 3, 2021

@gabemontero got it, sorry :)

@gabemontero
Copy link
Contributor

@gabemontero got it, sorry :)

no worries @alicerum :-)

@alicerum
Copy link
Author

alicerum commented Feb 4, 2021

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2021
@alicerum
Copy link
Author

alicerum commented Feb 4, 2021

/retitle Bug 1924128: Allow RHE7 /run contents for build fs test

@openshift-ci-robot openshift-ci-robot changed the title WIP - Bug 1924128: Allow RHE7 /run contents for build fs test Bug 1924128: Allow RHE7 /run contents for build fs test Feb 4, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2021
@alicerum
Copy link
Author

alicerum commented Feb 4, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9df035d into openshift:master Feb 5, 2021
@openshift-ci-robot
Copy link

@alicerum: All pull requests linked via external trackers have merged:

Bugzilla bug 1924128 has been moved to the MODIFIED state.

In response to this:

Bug 1924128: Allow RHE7 /run contents for build fs test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/cherrypick release-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

@gabemontero: new pull request created: #25864

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alicerum @openshift-ci-robot @gabemontero @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot