-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1924128: Allow RHE7 /run contents for build fs test #25854
Bug 1924128: Allow RHE7 /run contents for build fs test #25854
Conversation
On RHEL7 workers /run contents for build fs test are different from all thore variants we are checking, which makes test fail on RHEL7 workers. Adding correct contents to the list of checked contents should help
@alicerum: This pull request references Bugzilla bug 1924128, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gabemontero |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 1924128, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alicerum if the want the WIP label to be placed on the PR (which would prevent merging even if inadvertently tagged for merge while you are still working on it), I believe you put the You also use the hold command per the list of prow commands at https://go.k8s.io/bot-commands?repo=openshift%2Forigin |
fwiw I think it is good to go, unless the e2e's find some yaml formatting issues or some such so I'll |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alicerum, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gabemontero got it, sorry :) |
no worries @alicerum :-) |
/unhold |
/retitle Bug 1924128: Allow RHE7 /run contents for build fs test |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
8 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@alicerum: All pull requests linked via external trackers have merged: Bugzilla bug 1924128 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.6 |
@gabemontero: new pull request created: #25864 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On RHEL7 workers /run contents for build fs test are different from all the other variants we are checking, which makes test fail on RHEL7 workers as seen in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1924128
Adding correct string from RHEL7 worker to the list of checked contents should help.