Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Enable crictl on node test #26144

Closed
wants to merge 1 commit into from
Closed

WIP: Enable crictl on node test #26144

wants to merge 1 commit into from

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 10, 2021 •
edited

This re-enables the crictl test because it automatically gets skipped.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
To complete the pull request process, please assign derekwaynecarr after the PR has been reviewed.
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

/test verify

@saschagrunert
Enable crictl on node test
4654e21 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/test e2e-aws-fips

@saschagrunert
Copy link
Member Author

At least the test got auto-skipped: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26144/pull-ci-openshift-origin-master-e2e-aws-disruptive/1391687789384306688

/retest

@saschagrunert saschagrunert changed the title WIP: Enable crictl on node test Enable crictl on node test May 10, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@saschagrunert saschagrunert changed the title Enable crictl on node test WIP: Enable crictl on node test May 10, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2021
@saschagrunert
Copy link
Member Author

Ah, but for GCP we now have some failure logs:

May 10 11:24:49.717: INFO: Fetching cloud provider for "gce"
I0510 11:24:49.720148   25867 gce.go:918] Using DefaultTokenSource &oauth2.reuseTokenSource{new:jwt.jwtSource{ctx:(*context.emptyCtx)(0xc0000840e0), conf:(*jwt.Config)(0xc001446500)}, mu:sync.Mutex{state:0, sema:0x0}, t:(*oauth2.Token)(nil)}
W0510 11:24:49.784346   25867 gce.go:485] No network name or URL specified.
I0510 11:24:49.784368   25867 gce.go:506] managing multiple zones: [us-east1-b us-east1-c us-east1-d]
[BeforeEach] [Top Level]
  github.com/openshift/origin/test/extended/util/framework.go:1440
[BeforeEach] [Top Level]
  github.com/openshift/origin/test/extended/util/framework.go:1440
[BeforeEach] [Top Level]
  github.com/openshift/origin/test/extended/util/test.go:59
[BeforeEach] [sig-node] crictl
  k8s.io/kubernetes@v1.21.0-rc.0/test/e2e/framework/framework.go:185
STEP: Creating a kubernetes client
STEP: Building a namespace api object, basename crictl
May 10 11:24:51.205: INFO: About to run a Kube e2e test, ensuring namespace is privileged
W0510 11:24:51.637121   25867 warnings.go:70] policy/v1beta1 PodSecurityPolicy is deprecated in v1.21+, unavailable in v1.25+
May 10 11:24:51.637: INFO: Found PodSecurityPolicies; testing pod creation to see if PodSecurityPolicy is enabled
May 10 11:24:51.665: INFO: No PSP annotation exists on dry run pod; assuming PodSecurityPolicy is disabled
STEP: Waiting for a default service account to be provisioned in namespace
[BeforeEach] [sig-node] crictl
  k8s.io/kubernetes@v1.21.0-rc.0/test/e2e/node/crictl.go:33
[It] should be able to run crictl on the node [Suite:openshift/conformance/parallel] [Suite:k8s]
  k8s.io/kubernetes@v1.21.0-rc.0/test/e2e/node/crictl.go:40
STEP: Getting all nodes' SSH-able IP addresses
May 10 11:24:51.765: INFO: No external IP address on nodes, falling back to internal IPs
STEP: SSH'ing to node "10.0.0.4:22" to run "sudo crictl version"
error dialing core@:22: 'dial tcp :22: connect: connection refused', retrying
May 10 11:24:56.768: FAIL: Ran "sudo crictl version" on "10.0.0.4:22", got error error getting SSH client to core@:22: dial tcp :22: connect: connection refused

Full Stack Trace
github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00030bc80, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113 +0xa3
github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0xc00030bc80, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:64 +0x15c
github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0xc001087f80, 0x87965a0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/it_node.go:26 +0x87
github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0xc001f56870, 0x0, 0x87965a0, 0xc00048c040)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/spec/spec.go:215 +0x72f
github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0xc001f56870, 0x87965a0, 0xc00048c040)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/spec/spec.go:138 +0xf2
github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0xc001f01040, 0xc001f56870, 0x0)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/specrunner/spec_runner.go:200 +0x111
github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0xc001f01040, 0x1)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/specrunner/spec_runner.go:170 +0x147
github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0xc001f01040, 0xc002778a60)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/specrunner/spec_runner.go:66 +0x117
github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0xc00031bef0, 0x8796880, 0xc001d1dcc0, 0x0, 0x0, 0xc0007ee050, 0x1, 0x1, 0x8868538, 0xc00048c040, ...)
	github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/suite/suite.go:62 +0x426
github.com/openshift/origin/pkg/test/ginkgo.(*TestOptions).Run(0xc0020f8360, 0xc000127080, 0x1, 0x1, 0x7c9630e, 0x46b1940)
	github.com/openshift/origin/pkg/test/ginkgo/cmd_runtest.go:61 +0x418
main.newRunTestCommand.func1.1()
	github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:426 +0x4e
github.com/openshift/origin/test/extended/util.WithCleanup(0xc00221fc18)
	github.com/openshift/origin/test/extended/util/test.go:167 +0x5f
main.newRunTestCommand.func1(0xc001b6b340, 0xc000127080, 0x1, 0x1, 0x0, 0x0)
	github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:426 +0x333
github.com/spf13/cobra.(*Command).execute(0xc001b6b340, 0xc000126f90, 0x1, 0x1, 0xc001b6b340, 0xc000126f90)
	github.com/spf13/cobra@v1.1.1/command.go:850 +0x472
github.com/spf13/cobra.(*Command).ExecuteC(0xc001b6a840, 0x0, 0x879de80, 0xb6463f0)
	github.com/spf13/cobra@v1.1.1/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.1.1/command.go:895
main.main.func1(0xc001b6a840, 0x0, 0x0)
	github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:84 +0x94
main.main()
	github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:85 +0x42c
[AfterEach] [sig-node] crictl
  k8s.io/kubernetes@v1.21.0-rc.0/test/e2e/framework/framework.go:186
STEP: Collecting events from namespace "e2e-crictl-2714".
STEP: Found 1 events.
May 10 11:24:56.858: INFO: At 2021-05-10 11:24:49 +0000 UTC - event for e2e-crictl-2714: {namespace-security-allocation-controller } CreatedSCCRanges: created SCC ranges
May 10 11:24:56.942: INFO: POD  NODE  PHASE  GRACE  CONDITIONS
May 10 11:24:56.942: INFO: 
May 10 11:24:57.045: INFO: skipping dumping cluster info - cluster too large
STEP: Destroying namespace "e2e-crictl-2714" for this suite.
fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: May 10 11:24:56.768: Ran "sudo crictl version" on "10.0.0.4:22", got error error getting SSH client to core@:22: dial tcp :22: connect: connection refused

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2021

@saschagrunert: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 4654e21 link /test e2e-aws-fips
ci/prow/e2e-aws-disruptive 4654e21 link /test e2e-aws-disruptive
ci/prow/e2e-gcp-disruptive 4654e21 link /test e2e-gcp-disruptive
ci/prow/e2e-gcp 4654e21 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saschagrunert
Copy link
Member Author

I think making the test more failure safe might be the right approach. Opening kubernetes/kubernetes#101866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@saschagrunert