Bug 1963730: updates local kubeconfig conformance test to cover multiple paths #26204
Conversation
openshift-ci
bot
added
the
bugzilla/severity-low
|
@p0lyn0mial: This pull request references Bugzilla bug 1963730, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/assign @sttts |
| continue // make sure the other paths that follow will fail | ||
| } | ||
| if commandSucceeded && foundGoodKubeConfig { | ||
| g.Fail("only one path should have a valid kubeconfig") |
There was a problem hiding this comment.
unless we run the test against previous versions as well.
|
/retest |
…econfig to cover multiple paths openshift/library-go#1098 moved the cert directory under a new path hence we need to cover both the old and the new paths
p0lyn0mial
force-pushed
the
adapt-conformance-kubeconfigs-to-new-path
branch
from
caa6c2b
to
fba794b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold as it is not clear if the DR scripts will work |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold for 4.8 we decided to create certificates in an atomic way. In 4.9 we are going to change the paths. |
|
/bugzilla refresh The main branch will open for development of next OCP version. Recalculating validity of PRs linked to this PR. |
|
@openshift-bot: This pull request references Bugzilla bug 1963730, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/invalid-bug
|
@p0lyn0mial: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
@p0lyn0mial: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@p0lyn0mial: This pull request references Bugzilla bug 1963730. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/library-go#1098 moved the cert directory under a new path hence we need to cover both the old and the new paths.
This PR also unblocks openshift/cluster-kube-apiserver-operator#1138