Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update #26297

Merged
merged 1 commit into from Aug 8, 2021
Merged

[release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update #26297

merged 1 commit into from Aug 8, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #26208

/assign vrutkovs

@vrutkovs
testPodSandboxCreation: skip sandbox errors for pods which were not d…
32e2065 
…eleted during network update

"pods should successfully create sandboxes" test should mark pod events as flakes if network is being updated. These pods eventually get created, so the test is too strict
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 1, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

@openshift-cherrypick-robot: Bugzilla bug 1970315 has been cloned as Bugzilla bug 1978090. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update

In response to this:

[release-4.8] Bug 1970315: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1970315: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update [release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update Jul 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1978090, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1970315 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1970315 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

[release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 1, 2021
@openshift-ci openshift-ci bot requested a review from zhaozhanqi July 1, 2021 06:29
@vrutkovs
Copy link
Member

vrutkovs commented Jul 1, 2021

/retest

7 similar comments
@vrutkovs
Copy link
Member

vrutkovs commented Jul 1, 2021

/retest

@vrutkovs
Copy link
Member

vrutkovs commented Jul 2, 2021

/retest

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 2, 2021

/retest

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 2, 2021

/retest

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 3, 2021

/retest

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 4, 2021

/retest

@ravisantoshgudimetla
Copy link
Contributor

/retest

@jluhrsen
Copy link
Contributor

jluhrsen commented Jul 8, 2021

I'm not sure this e2e-aws-proxy job is ever passing
/retest

@vrutkovs
Copy link
Member

/retest

@dmage
Copy link
Member

dmage commented Jul 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@bparees
Copy link
Contributor

bparees commented Aug 5, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.90

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

/retest

upgrade related tests should be fixed

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot merged commit 89b5077 into openshift:release-4.8 Aug 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1978090 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1978090: testPodSandboxCreation: skip sandbox errors for pods which were not deleted during network update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@vrutkovs vrutkovs

@dmage dmage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @vrutkovs @jluhrsen @ravisantoshgudimetla @dmage @bparees @ecordell @openshift-bot