Bug 1980338: test/cmd/newapp: update app name to match existing tag #26302

vrutkovs · 2021-07-01T19:57:35Z

Fixes several test/cmd entries to match the current state of imagestreams.
Includes #26292 to have Dockerhub pullsecret placed, so that import would not hit rate limits

openshift-ci · 2021-07-01T19:57:36Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-01T19:57:51Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-02T12:51:26Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-02T20:20:04Z

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OTA-418: test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cuppett · 2021-07-06T20:24:38Z

test/cmd/newapp.sh

-os::cmd::expect_success 'oc new-app --docker-image=library/php https://github.com/sclorg/cakephp-ex --strategy=source'
-os::cmd::try_until_success 'oc get istag php:latest -n test-imagestreams'
-os::cmd::expect_success 'oc create istag php:latest --from=openshift/php:7.1 -n openshift'
+os::cmd::expect_success 'oc new-app --docker-image=quay.io/centos7/php-72-centos7 https://github.com/sclorg/cakephp-ex --strategy=source --name=php'


If it helps, here's where the an official UBI imagestream comes from:

registry.access.redhat.com/ubi7/php-73

https://catalog.redhat.com/software/containers/ubi7/php-73/5da0228fdd19c70159f4601b

7.2 is already EOL, 7.3 is next and 7.4 is only published for ubi8 currently.

I see in 9dc7e4b you are using ubi8. In that case, registry.access.redhat.com/ubi8/php-74 will give you the most legs. :)

Updated quay.io images to registry.access.redhat.com. Its a mix of UBI7/UBI8 now, we can improve this later on

bparees · 2021-07-06T21:25:28Z

for the image pullspec changes themselves, as long as the test is still passing you are probably fine to change them, the tests are exercising the commands, not the images, so as long as the new image your ref'ing is a functional/behavioral equivalent to the old one, it should be fine.

sttts · 2021-07-06T22:12:58Z

/assign @soltysh

dcbw · 2021-07-07T00:36:58Z

hack/test-cmd.sh

+#  - ADMIN_KUBECONFIG
+#  - REAL_HOME
+# Arguments:
+#  None


@vrutkovs doesn't it take an optional namespace as an argument?

Good catch, thanks. Fixed this in 6757e9f

In CI this relies on the docker creds are in the homedir. It then mounts them into the test container.

Ruby 2.3 was removed from examples/image-streams/image-streams-centos7.json

Nodejs imagestream seems to be unavailable

soltysh

/lgtm
/approve

openshift-ci · 2021-07-08T12:15:52Z

@vrutkovs: This pull request references Bugzilla bug 1980338, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (3.11.z) matches configured target release for branch (3.11.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Bug 1980338: test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton · 2021-07-08T13:55:40Z

/approve

openshift-ci · 2021-07-08T13:58:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, soltysh, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~hack/OWNERS~~ [smarterclayton]
~~test/cmd/OWNERS~~ [smarterclayton,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-07-08T13:59:22Z

@vrutkovs: All pull requests linked via external trackers have merged:

openshift/origin#26302

Bugzilla bug 1980338 has been moved to the MODIFIED state.

In response to this:

Bug 1980338: test/cmd/newapp: update app name to match existing tag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from danwinship and soltysh July 1, 2021 19:58

vrutkovs force-pushed the 3.11-fix-ruby27 branch 3 times, most recently from dde947d to 0a79443 Compare July 2, 2021 12:17

vrutkovs force-pushed the 3.11-fix-ruby27 branch 4 times, most recently from 4d2a152 to 9ae0511 Compare July 2, 2021 18:50

vrutkovs changed the title ~~test/cmd/newapp: update app name to match existing tag~~ OTA-418: test/cmd/newapp: update app name to match existing tag Jul 2, 2021

cuppett reviewed Jul 6, 2021

View reviewed changes

openshift-ci bot assigned soltysh Jul 6, 2021

dcbw reviewed Jul 7, 2021

View reviewed changes

vrutkovs force-pushed the 3.11-fix-ruby27 branch from 9ae0511 to 8436993 Compare July 7, 2021 08:11

brenton and others added 2 commits July 7, 2021 10:13

Loading the imagepullsecret for test-cmd.sh

6757e9f

In CI this relies on the docker creds are in the homedir. It then mounts them into the test container.

test/cmd/newapp: update app name to match existing tag

819f2c2

vrutkovs force-pushed the 3.11-fix-ruby27 branch from 8436993 to 36670d0 Compare July 7, 2021 08:13

vrutkovs added 6 commits July 7, 2021 11:40

test.cmd/newapp: use UBI7 PHP image for new-app tests

e6dac8c

test/cmd/new-app: fix perl image references

862f8ab

test/cmd/set-image: use ruby 2.5

4e2e6e5

Ruby 2.3 was removed from examples/image-streams/image-streams-centos7.json

test/cmd/timeout: create node app from UBI image

ac7519b

test/cmd/triggers: create ruby image from UBI image

5f8b6e6

test/cmd/printer: fix imagestream name to "php"

5112b32

Nodejs imagestream seems to be unavailable

vrutkovs force-pushed the 3.11-fix-ruby27 branch from 36670d0 to 5112b32 Compare July 7, 2021 09:42

soltysh approved these changes Jul 7, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021

vrutkovs changed the title ~~OTA-418: test/cmd/newapp: update app name to match existing tag~~ Bug 1980338: test/cmd/newapp: update app name to match existing tag Jul 8, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 8, 2021

openshift-ci bot requested a review from zhouying7780 July 8, 2021 12:15

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021

openshift-merge-robot merged commit c192152 into openshift:release-3.11 Jul 8, 2021

tsmetana mentioned this pull request Jul 9, 2021

Bug 1970609: use proper scheme with migrator tool #26245

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1980338: test/cmd/newapp: update app name to match existing tag #26302

Bug 1980338: test/cmd/newapp: update app name to match existing tag #26302

vrutkovs commented Jul 1, 2021 •

edited

openshift-ci bot commented Jul 1, 2021

openshift-ci bot commented Jul 1, 2021

openshift-ci bot commented Jul 2, 2021

openshift-ci bot commented Jul 2, 2021 •

edited

cuppett Jul 6, 2021

cuppett Jul 6, 2021

vrutkovs Jul 7, 2021

bparees commented Jul 6, 2021

sttts commented Jul 6, 2021

dcbw Jul 7, 2021

vrutkovs Jul 7, 2021

soltysh left a comment

openshift-ci bot commented Jul 8, 2021

smarterclayton commented Jul 8, 2021

openshift-ci bot commented Jul 8, 2021

openshift-ci bot commented Jul 8, 2021

Bug 1980338: test/cmd/newapp: update app name to match existing tag #26302

Bug 1980338: test/cmd/newapp: update app name to match existing tag #26302

Conversation

vrutkovs commented Jul 1, 2021 • edited

openshift-ci bot commented Jul 1, 2021

openshift-ci bot commented Jul 1, 2021

openshift-ci bot commented Jul 2, 2021

openshift-ci bot commented Jul 2, 2021 • edited

cuppett Jul 6, 2021

Choose a reason for hiding this comment

cuppett Jul 6, 2021

Choose a reason for hiding this comment

vrutkovs Jul 7, 2021

Choose a reason for hiding this comment

bparees commented Jul 6, 2021

sttts commented Jul 6, 2021

dcbw Jul 7, 2021

Choose a reason for hiding this comment

vrutkovs Jul 7, 2021

Choose a reason for hiding this comment

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jul 8, 2021

smarterclayton commented Jul 8, 2021

openshift-ci bot commented Jul 8, 2021

openshift-ci bot commented Jul 8, 2021

vrutkovs commented Jul 1, 2021 •

edited

openshift-ci bot commented Jul 2, 2021 •

edited