-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1925524: comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins) #26317
Bug 1925524: comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins) #26317
Conversation
…to remote repo and openshift/jenkins)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gabemontero: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1925524 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gabemontero: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1925524 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
See openshift/jenkins#1297 for the tl;dr
But basically, the commented out test alway fails with
since the local repo is created in the test pod, not the jenkins pod.
The validation of bc updates for env vars when the test fails so early is not what we are after.
Short term: commenting out this test to help unblock pulling in sync plugin updates.
Immediately after: I'm moving this test from a locally created repo to an actual https://github.com/openshift repo, where we can then validate the actual end to end scenario of an
oc new-app <repo with jenkinsfile> --strategy=pipeline --build-env=FOO1=BAR1
actually working
/assign @coreydaley