Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1925524: comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins) #26317

Merged

Conversation

gabemontero
Copy link
Contributor

See openshift/jenkins#1297 for the tl;dr

But basically, the commented out test alway fails with

Cloning the remote Git repository
Cloning repository /tmp/test-build-app-pipeline544874952/test-build-app-pipeline.git
 > git init /var/lib/jenkins/jobs/e2e-test-jenkins-pipeline-9bmz9/jobs/e2e-test-jenkins-pipeline-9bmz9-test-build-app-pipeline/workspace@script # timeout=10
Fetching upstream changes from /tmp/test-build-app-pipeline544874952/test-build-app-pipeline.git
 > git --version # timeout=10
 > git --version # 'git version 2.27.0'
 > git fetch --tags --force --progress -- /tmp/test-build-app-pipeline544874952/test-build-app-pipeline.git +refs/heads/*:refs/remotes/origin/* # timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Command "git fetch --tags --force --progress -- /tmp/test-build-app-pipeline544874952/test-build-app-pipeline.git +refs/heads/*:refs/remotes/origin/*" returned status code 128:
stdout: 
stderr: fatal: '/tmp/test-build-app-pipeline544874952/test-build-app-pipeline.git' does not appear to be a git repository
fatal: Could not read from remote repository.

since the local repo is created in the test pod, not the jenkins pod.

The validation of bc updates for env vars when the test fails so early is not what we are after.

Short term: commenting out this test to help unblock pulling in sync plugin updates.

Immediately after: I'm moving this test from a locally created repo to an actual https://github.com/openshift repo, where we can then validate the actual end to end scenario of an

oc new-app <repo with jenkinsfile> --strategy=pipeline --build-env=FOO1=BAR1

actually working

/assign @coreydaley

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2519e32 into openshift:master Jul 12, 2021
@gabemontero gabemontero deleted the dbg-fix-jenkins-1297 branch July 12, 2021 12:18
@gabemontero gabemontero changed the title comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins) Bug 1925524: comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins) Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@gabemontero: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1925524 has not been moved to the MODIFIED state.

In response to this:

Bug 1925524: comment out broken local git, env var, jenkins pipeline test (moving to remote repo and openshift/jenkins)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@gabemontero: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1925524 has not been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants