-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for controlplanetopology=external #26549
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold I didn't realize the framework is an import, seems I have to find another global for this |
Plugging the controlplanetopology setting through will likely be done in #26537 |
@alvaroaleman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
In hypershift, the controlplane components are not selfhosted but run in a different cluster. This means that certain assertions like "find openshift-controller-manager pod and check if its log contains a specific line" can not work.
Luckily, the changes in behavior for this were already implemented for the IBMCloud provider, this PR is mostly about plugging the Controlplanetopology field through the testcontext and and treating a value of external identical to "ibmcloud" in util.WaitForInternalRegistryHostname (There will likely be more followups to switch behavior based on this).
/cc @csrwng
Ref https://issues.redhat.com/browse/HOSTEDCP-257