Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2022797: Switch the cluster-role-reapers test to Serial #26603

Merged
merged 1 commit into from Nov 17, 2021

Conversation

derekhiggins
Copy link
Contributor

@derekhiggins derekhiggins commented Nov 12, 2021

Switch the cluster-role-reapers test to Serial

This test run the cli command
"oc adm prune auth clusterrole/edit"
which prunes out the rolebindings for the other test that
are running at the same time.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2021
@derekhiggins derekhiggins changed the title [WIP] Remove the role-reapers tests Bug 2022797: [WIP] Remove the role-reapers tests Nov 12, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2021

@derekhiggins: This pull request references Bugzilla bug 2022797, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2022797: [WIP] Remove the role-reapers tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 12, 2021
@derekhiggins
Copy link
Contributor Author

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@ardaguclu
Copy link
Member

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

Since failures are intermittent, it would be better to retest couple of times

@derekhiggins
Copy link
Contributor Author

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@ardaguclu
Copy link
Member

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@ardaguclu
Copy link
Member

/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-virtualmedia

@ardaguclu
Copy link
Member

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-virtualmedia

Results are pretty good

@ardaguclu
Copy link
Member

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-virtualmedia

@derekhiggins derekhiggins changed the title Bug 2022797: [WIP] Remove the role-reapers tests Bug 2022797: Switch the cluster-role-reapers test to Serial Nov 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

@derekhiggins: This pull request references Bugzilla bug 2022797, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2022797: Switch the cluster-role-reapers test to Serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Contributor Author

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ipi-serial-ipv4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

@derekhiggins: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-cgroupsv2
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-single-node
  • /test e2e-aws-single-node-serial
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-aws-single-node
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-builds
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test e2e-metal-ipi-serial-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member

/test e2e-metal-ipi-serial

According to the latest test runs(https://prow.ci.openshift.org/pr-history/?org=openshift&repo=origin&pr=26603), there was no flaky auth test failed. I think, this test causes flakiness in parallel suite.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@andfasano
Copy link
Contributor

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-serial

@bfournie
Copy link
Contributor

/test e2e-metal-ipi-ovn-dualstack

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@openshift-bot: This pull request references Bugzilla bug 2022797, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@derekhiggins: This pull request references Bugzilla bug 2022797, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 16, 2021
@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 16, 2021
@stbenjam
Copy link
Member

@derekhiggins Could you add more detail to the PR description, perhaps what's in your BZ comment?

Also, I'm wondering if this shouldn't be using the namespaced oc client (ocns) instead?

		o.Expect(oc.Run("adm", "prune", "auth").Args("clusterrole/edit").Execute()).To(o.Succeed())

@soltysh Could you take a look at this?
/assign @soltysh

This test run the cli command
"oc adm prune auth clusterrole/edit"
which prunes out the rolebindings for the other test that
are running at the same time.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@derekhiggins: This pull request references Bugzilla bug 2022797, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2022797: Switch the cluster-role-reapers test to Serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Contributor Author

@derekhiggins Could you add more detail to the PR description, perhaps what's in your BZ comment?

done

@deads2k
Copy link
Contributor

deads2k commented Nov 16, 2021

@derekhiggins Could you add more detail to the PR description, perhaps what's in your BZ comment?

Also, I'm wondering if this shouldn't be using the namespaced oc client (ocns) instead?

You cannot prune a clusterrole with namespaced client.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, deads2k, derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2021

@derekhiggins: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 3b2e492 link false /test e2e-gcp-csi
ci/prow/e2e-aws-single-node 3b2e492 link false /test e2e-aws-single-node
ci/prow/e2e-agnostic-cmd 3b2e492 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor

deads2k commented Nov 17, 2021

/override ci/prow/e2e-gcp-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Nov 17, 2021

This passed tests before and it fixes new failures.

@deads2k deads2k merged commit 30cda94 into openshift:master Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@derekhiggins: All pull requests linked via external trackers have merged:

Bugzilla bug 2022797 has been moved to the MODIFIED state.

In response to this:

Bug 2022797: Switch the cluster-role-reapers test to Serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@derekhiggins
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@derekhiggins: new pull request created: #26618

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants