New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct pathological event detection #26994

Merged

deads2k merged 1 commit into openshift:master from deads2k:pathological-event

Apr 8, 2022

Contributor

deads2k commented Apr 7, 2022

found in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26982/pull-ci-openshift-origin-master-e2e-aws-serial/1511793616459141120 when it did not detect the repeated Malscheduled event.


          correct pathological event detection

268a064

openshift-ci bot requested review from bparees and smarterclayton

April 7, 2022 21:33

openshift-ci bot added the approved label

deads2k commented

View reviewed changes

pkg/synthetictests/duplicated_events.go

               			if allowed {
               				continue
               			}
+              			displayToCount[eventDisplayMessage] = times

Contributor Author

deads2k Apr 7, 2022

this is used further down to actually decide about flake or fail.

Contributor

dgoodwin commented Apr 8, 2022

/lgtm

openshift-ci bot assigned dgoodwin

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 8, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

deads2k commented Apr 8, 2022

/override ci/prow/e2e-gcp-upgrade

This needs to be restored in master and that job only failed on disruption

Contributor

openshift-ci bot commented Apr 8, 2022

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp-upgrade

In response to this:

/override ci/prow/e2e-gcp-upgrade

This needs to be restored in master and that job only failed on disruption

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deads2k merged commit d0ece94 into openshift:master

Contributor

openshift-ci bot commented Apr 8, 2022

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade	`268a064`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-aws-single-node-upgrade	`268a064`	link	false	`/test e2e-aws-single-node-upgrade`
ci/prow/e2e-agnostic-cmd	`268a064`	link	false	`/test e2e-agnostic-cmd`
ci/prow/e2e-aws-single-node	`268a064`	link	false	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment