Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egressip: avoid curl hanging when sending probes #27379

Merged
merged 1 commit into from
Sep 30, 2022
Merged

egressip: avoid curl hanging when sending probes #27379

merged 1 commit into from
Sep 30, 2022

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Aug 26, 2022 •
edited
Loading

Avoids curl hanging and preventing:

  • the test to be tear down up properly, making follow up tests to fail
  • the retry mechanism in place from happening

Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com

@jcaamano
Copy link
Contributor Author

@andreaskaris

PTAL

@jcaamano jcaamano mentioned this pull request Aug 26, 2022
Merged
@openshift-ci openshift-ci bot requested review from dcbw and knobunc August 26, 2022 15:37
@jcaamano
Copy link
Contributor Author

jcaamano commented Sep 1, 2022

/retest

1 similar comment
@andreaskaris
Copy link
Contributor

/retest

@jcaamano
egressip: avoid curl hanging when sending probes
6be69c6 
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/retest-failed

@andreaskaris
Copy link
Contributor

/retest

1 similar comment
@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/test e2e-aws-ovn-serial
Incredible - this constantly fails on 2-3 completely unrelated tests

@andreaskaris
Copy link
Contributor

/retest

3 similar comments
@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/retest

@dcbw
Copy link
Contributor

dcbw commented Sep 28, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreaskaris, dcbw, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0ab3ade and 2 for PR HEAD 6be69c6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e25bd15 and 1 for PR HEAD 6be69c6 in total

@jcaamano
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8767b07 and 0 for PR HEAD 6be69c6 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022 •
edited
Loading

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade a064d6a link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-aws-serial a064d6a link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 6be69c6 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/hold

Revision 6be69c6 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@jcaamano
Copy link
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8767b07 and 2 for PR HEAD 6be69c6 in total

@openshift-merge-robot openshift-merge-robot merged commit 6c3592b into openshift:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskaris andreaskaris andreaskaris requested changes

@dcbw dcbw Awaiting requested review from dcbw

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@andreaskaris andreaskaris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcaamano @andreaskaris @dcbw @openshift-ci-robot @openshift-merge-robot