-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upgrade and conformance alert backstop tests #27533
Merge upgrade and conformance alert backstop tests #27533
Conversation
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-gcp-ovn-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OCPBUGS-3633: Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops"
…-27547-to-release-4.12 [release-4.12] OCPBUGS-3649: Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops"
TRT-664
This change brings together two tests that were originally copied code that has drifted in the years since into one code path. (post-upgrade alert check, post conformance/e2e alert check)
I've maintained the ability to allow different sets of pending/firing alerts for each use case.
Allowed alerts live in two similar files side by side for easier diffability.
No functional changes are intended, other than combining to one method of checking for cluster tech preview feature gate which looked most correct, and syncing the alerts we'd allow in this case. (one path allowed two alerts, the other path allowed one and in a more specific form, they both now allow two in the more generic form without a namespace limitation)