Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upgrade and conformance alert backstop tests #27533

Merged
merged 11 commits into from
Nov 10, 2022

Conversation

dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented Nov 8, 2022

TRT-664

This change brings together two tests that were originally copied code that has drifted in the years since into one code path. (post-upgrade alert check, post conformance/e2e alert check)

I've maintained the ability to allow different sets of pending/firing alerts for each use case.

Allowed alerts live in two similar files side by side for easier diffability.

No functional changes are intended, other than combining to one method of checking for cluster tech preview feature gate which looked most correct, and syncing the alerts we'd allow in this case. (one path allowed two alerts, the other path allowed one and in a more specific form, they both now allow two in the more generic form without a namespace limitation)

  • Remove TEST_UNSUPPORTED_ALLOW_VERSION_SKEW which appears unused in release repo.
  • wip: breakout code to comparable locations
  • wip: begin syncing code paths
  • wip: Break alert allowances out to separate files for comparison
  • wip: Sync TechPreview feature gate check and allowances
  • wip: Fix conformance compile errors
  • wip: Fork logic on flake reporting, unsure what the implications of choosing here are
  • wip: Make text in test messages more generic as we re-use the function
  • wip: Extract subtle differences in how test duration is calculated
  • wip: Drop the temp conformance.go file, now merged into check.go
  • Add some godoc

@dgoodwin dgoodwin changed the title merge alert backstops Merge upgrade and conformance alert backstop tests Nov 8, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

@dgoodwin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 87bb855 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-openstack-ovn 87bb855 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 87bb855 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-sdn 87bb855 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-upgrade 87bb855 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 87bb855 link false /test e2e-aws-ovn-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

/lgtm
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-gcp-ovn-upgrade
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-gcp-ovn-upgrade

In response to this:

/lgtm
/override ci/prow/e2e-aws-ovn-fips
/override ci/prow/e2e-gcp-ovn-upgrade
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a747f94 into openshift:master Nov 10, 2022
dgoodwin added a commit to dgoodwin/origin that referenced this pull request Nov 14, 2022
…backstops"

This reverts commit a747f94, reversing
changes made to 63e7542.
openshift-merge-robot added a commit that referenced this pull request Nov 14, 2022
OCPBUGS-3633: Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops"
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/origin that referenced this pull request Nov 14, 2022
…backstops"

This reverts commit a747f94, reversing
changes made to 63e7542.
openshift-merge-robot added a commit that referenced this pull request Nov 15, 2022
…-27547-to-release-4.12

[release-4.12] OCPBUGS-3649: Revert "Merge pull request #27533 from dgoodwin/merge-alert-backstops"
tjungblu pushed a commit to tjungblu/origin that referenced this pull request Apr 11, 2023
…backstops"

This reverts commit a747f94, reversing
changes made to 63e7542.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants