Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-3819: Add bond cni test #27554

Merged

Conversation

mmirecki
Copy link

Adding a test case for the bond-cni.
The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

Adding a test case for the bond-cni.
The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@mmirecki: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Add bond cni test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Nov 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@mmirecki: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 41b7130 link false /test e2e-gcp-csi
ci/prow/e2e-aws-single-node-upgrade 41b7130 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-aws-cgroupsv2 41b7130 link false /test e2e-aws-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgoncalves
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@mmirecki mmirecki changed the title Add bond cni test CNF-6648: Add bond cni test Nov 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2022

@mmirecki: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

CNF-6648: Add bond cni test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mmirecki: No Jira bug is referenced in the title of this pull request.
To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki mmirecki changed the title CNF-6648: Add bond cni test OCPBUGS-3819: Add bond cni test Nov 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2022

@mmirecki: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-3819: Add bond cni test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 17, 2022
@openshift-ci-robot
Copy link

@mmirecki: This pull request references Jira Issue OCPBUGS-3819, which is invalid:

  • expected Jira Issue OCPBUGS-3819 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding a test case for the bond-cni.
The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mmirecki: This pull request references Jira Issue OCPBUGS-3819, which is invalid:

  • expected Jira Issue OCPBUGS-3819 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mmirecki: This pull request references Jira Issue OCPBUGS-3819, which is invalid:

  • expected Jira Issue OCPBUGS-3819 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@mmirecki: This pull request references Jira Issue OCPBUGS-3819, which is invalid:

  • expected Jira Issue OCPBUGS-3819 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@cgoncalves: This pull request references Jira Issue OCPBUGS-3819, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgoncalves
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 17, 2022
@openshift-ci-robot
Copy link

@cgoncalves: This pull request references Jira Issue OCPBUGS-3819, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-3820 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-3820 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mmirecki
Copy link
Author

/cc @knobunc
Could you please take a look

@openshift-ci openshift-ci bot requested a review from knobunc November 17, 2022 10:53
@mmirecki
Copy link
Author

@knobunc @deads2k @dcbw @danwinship @smarterclayton @bparees @mfojtik
Can you please take a look at this?

@knobunc
Copy link
Contributor

knobunc commented Nov 28, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgoncalves, knobunc, mmirecki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@mmirecki
Copy link
Author

@dgoodwin @akram @coreydaley @dmage @gangwgr @jadhaj @jitendar-singh
Could you please apply the backport-risk-assessed, cherry-pick-approved labels?
Thanks

@jadhaj
Copy link

jadhaj commented Nov 30, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 30, 2022
@mmirecki
Copy link
Author

@kasturinarra @pamoedom @prietyc123 @stbenjam
Can you please apply the backport-risk-assessed label?
Thanks

@pamoedom
Copy link

Hi @mmirecki, please note that from the persons you pinged above, only @stbenjam has credentials to add backport-risk-assessed label. You can check here the whole list for both labels if needed.

Regards.

@bparees
Copy link
Contributor

bparees commented Nov 30, 2022

i'll apply it manually. Given this is affecting tests and not production code, the risk is low (the only real risk is that it opens a hole for a regression to be introduced elsewhere, and since it's adding tests, not changing them, that risk is also low)

@bparees bparees added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 3538c62 into openshift:release-4.11 Nov 30, 2022
@openshift-ci-robot
Copy link

@mmirecki: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3819 has been moved to the MODIFIED state.

In response to this:

Adding a test case for the bond-cni.
The test checks if a pod with a bond is created successfully, and then checks connectivity between two pods with bond interfaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet