Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug #27668

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug #27668

merged 1 commit into from
Jan 19, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #27630

/assign dobsonj

@ardaguclu
Fix intervalcreation incorrect year unit test bug
e7774ca 
Currently intervalcreation unit tests assures that the dates with static
year(2022) however, logs generated are now in 2023.

This PR fixes that.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2023
Merged
@openshift-ci openshift-ci bot requested review from csrwng and mfojtik January 17, 2023 23:23
@dobsonj dobsonj mentioned this pull request Jan 17, 2023
Closed
@dobsonj
Copy link
Member

dobsonj commented Jan 17, 2023

/lgtm
/assign @soltysh
I ran into this in a release-4.12 job

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-etcd-scaling e7774ca link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-single-node-upgrade e7774ca link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial e7774ca link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling e7774ca link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling e7774ca link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling e7774ca link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller petr-muller mentioned this pull request Jan 18, 2023
Closed
@petr-muller
Copy link
Member

/cc

@dobsonj
Copy link
Member

dobsonj commented Jan 19, 2023

/retitle [release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug
This is blocking #27667 and a few other PR's targeting release-4.12

/label backport-risk-assessed
It's a small low-risk unit test fix

@openshift-ci openshift-ci bot changed the title [release-4.12] Fix intervalcreation incorrect year unit test bug [release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug Jan 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 19, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5490, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4900 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4900 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #27630

/assign dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@dobsonj: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/retitle [release-4.12] OCPBUGS-5490: Fix intervalcreation incorrect year unit test bug
This is blocking #27667 and a few other PR's targeting release-4.12

/label backport-risk-assessed
It's a small low-risk unit test fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/approve
/cherry-pick-approved
/backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, LalatenduMohanty, openshift-cherrypick-robot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@stbenjam
Copy link
Member

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit 517ff51 into openshift:release-4.12 Jan 19, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-5490 has not been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #27630

/assign dobsonj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@mfojtik mfojtik Awaiting requested review from mfojtik

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@soltysh soltysh

@kasturinarra kasturinarra

@dobsonj dobsonj

@jadhaj jadhaj

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.