Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10824: fix: add poll to get deployment status and avoid false positive #27818

Merged
merged 1 commit into from Mar 28, 2023
Merged

OCPBUGS-10824: fix: add poll to get deployment status and avoid false positive #27818

merged 1 commit into from Mar 28, 2023

Conversation

eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Mar 24, 2023 •
edited

Noticed this test fail falsely in the CI due to querying the deployment before the status was updated by the controller.

It was rare locally, but I was able to replicate, adding the poll removed the false positive.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 24, 2023
@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-10824, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 24, 2023
@openshift-ci openshift-ci bot requested review from csrwng and soltysh March 24, 2023 04:47
@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-10824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Noticed this test fail falsely in the CI due to querying the the deployment before the status was updated by the controller.

It was rare locally, but I was able to replicate, adding the poll removed the false positive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@eggfoobar: This pull request references Jira Issue OCPBUGS-10824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Noticed this test fail falsely in the CI due to querying the deployment before the status was updated by the controller.

It was rare locally, but I was able to replicate, adding the poll removed the false positive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/assign @stbenjam

@eggfoobar
Copy link
Contributor Author

/cc @rphillips

@openshift-ci openshift-ci bot requested a review from rphillips March 24, 2023 05:09
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@stbenjam
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, rphillips, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 480c4d0 and 2 for PR HEAD 9101604 in total

@eggfoobar
Copy link
Contributor Author

/retest-required

2 similar comments
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2023 •
edited

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 9101604 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 9101604 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-etcd-scaling 9101604 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-etcd-scaling 9101604 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-agnostic-ovn-cmd 9101604 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node-serial 9101604 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling 9101604 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-rt-upgrade 9101604 link false /test e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit 9f98fce into openshift:master Mar 28, 2023
@openshift-ci-robot
Copy link

@eggfoobar: Jira Issue OCPBUGS-10824: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10824 has been moved to the MODIFIED state.

In response to this:

Noticed this test fail falsely in the CI due to querying the deployment before the status was updated by the controller.

It was rare locally, but I was able to replicate, adding the poll removed the false positive.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eggfoobar
Copy link
Contributor Author

/cherry-pick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2023
Merged
@openshift-cherrypick-robot
Copy link

@eggfoobar: new pull request created: #27825

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphillips rphillips rphillips left review comments

@csrwng csrwng Awaiting requested review from csrwng

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@rphillips rphillips

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eggfoobar @openshift-ci-robot @rphillips @stbenjam @openshift-cherrypick-robot @openshift-merge-robot