Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-10968: fix: add poll to get deployment status and avoid false positive #27825

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[release-4.13] OCPBUGS-10968: fix: add poll to get deployment status and avoid false positive #27825

merged 1 commit into from
Mar 29, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #27818

/assign eggfoobar

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 28, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10824 has been cloned as Jira Issue OCPBUGS-10968. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-10968: fix: add poll to get deployment status and avoid false positive

In response to this:

This is an automated cherry-pick of #27818

/assign eggfoobar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-10824: fix: add poll to get deployment status and avoid false positive [release-4.13] OCPBUGS-10968: fix: add poll to get deployment status and avoid false positive Mar 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 28, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-10968, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10824 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-10824 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #27818

/assign eggfoobar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.13] OCPBUGS-10968: fix: add poll to get deployment status and avoid false positive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bparees and csrwng March 28, 2023 12:15
@stbenjam
Copy link
Member

/lgtm
/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2dfafe5 and 2 for PR HEAD 882853c in total

@eggfoobar
Copy link
Contributor

/retest-required

@eggfoobar
Copy link
Contributor

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 882853c link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-csi 882853c link false /test e2e-aws-csi
ci/prow/e2e-aws-ovn-single-node-upgrade 882853c link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-vsphere-ovn-etcd-scaling 882853c link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-csi 882853c link false /test e2e-gcp-csi
ci/prow/e2e-openstack-ovn 882853c link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn-etcd-scaling 882853c link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-upgrade 882853c link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a4a5fd3 into openshift:release-4.13 Mar 29, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10968: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10968 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #27818

/assign eggfoobar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@kasturinarra kasturinarra

@eggfoobar eggfoobar

@jadhaj jadhaj

@sunilcio sunilcio

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.