Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change oc annotate cli test output check string #27932

Merged

Conversation

ardaguclu
Copy link
Member

Output of kubectl annotate command was incorrectly changed in kubernetes/kubernetes#112817. Although it was reverted back by kubernetes/kubernetes#118045, rebase v1.27.1 already landed and oc annotate test is failing in oc rebase PR openshift/oc#1420 (see https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oc/1420/pull-ci-openshift-oc-master-e2e-aws-ovn/1660630230638792704)

This PR mitigates the output check to let test passes in oc rebase.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@ardaguclu
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a24849d into openshift:master May 22, 2023
16 of 22 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 34e4b16 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial 34e4b16 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ardaguclu ardaguclu deleted the oc-annotate-output branch May 22, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants