WRKLDS-700: bump(k8s) to v1.27.2 #1420

atiratree · 2023-05-09T18:57:05Z

No description provided.

openshift-ci-robot · 2023-05-09T18:57:44Z

@atiratree: This pull request references WRKLDS-700 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

atiratree

I have tested the shadowing feature manually, but I need to check the unit tests as well and check that they are run properly.

atiratree · 2023-05-09T19:02:24Z

pkg/cli/cli.go

@@ -107,9 +107,12 @@ func NewDefaultOcCommand(in io.Reader, out, errout io.Writer) *cobra.Command {
 	cmdPathPieces := os.Args[1:]
 	pluginHandler := kubecmd.NewDefaultPluginHandler(plugin.ValidPluginFilenamePrefixes)

+	// TODO: this should be imported from kubectl


@ardaguclu we need to expose this in kubectl so we can consume it here.

Can you please review this shadowing commit carefully to make sure I have not missed anything?

we need to expose this in kubectl so we can consume it here.

ah, I missed that. I'll open a PR to fix that in next bump.

Can you please review this shadowing commit carefully to make sure I have not missed anything?

I compared the changes on upstream and there seems to be nothing missed. Thanks.

atiratree · 2023-05-09T19:03:29Z

/hold

atiratree · 2023-05-11T22:33:04Z

There is still not a parity between the oc and kubectl command. The main things I am seeing that need to be ported and tested:

profiling
plugin completion
normalization function and logging

#1424 is introducing plugin tests which are based on the upstream ones

atiratree · 2023-05-22T12:53:44Z

/retest-required

ardaguclu · 2023-05-22T12:55:02Z

/test e2e-metal-ipi-ovn-ipv6

soltysh

/lgtm
/approve

ardaguclu · 2023-05-22T16:55:45Z

Fix for oc annotate test failure openshift/origin#27932

ardaguclu · 2023-05-24T10:51:00Z

Fix for some of oc explain tests openshift/origin#27936

atiratree · 2023-05-24T11:26:49Z

here is an alternative to fix some of the oc explain failures: openshift/origin#27937

for the rest of the oc explain failure we have to wait for openshift-apiserver rebase to see that all of our resources will be discoverable in openapi v3 schema

atiratree · 2023-05-25T14:55:53Z

/retest

ardaguclu · 2023-06-07T10:31:05Z

/retest

flavianmissi · 2023-06-16T11:37:10Z

/retest

atiratree · 2023-06-19T11:41:16Z

API-1586: Bump k8s 1.27.2 openshift-apiserver#371 was bumped to k8s 1.27 so the tests should pass
rebased

atiratree · 2023-06-19T14:46:35Z

/retest-required

ardaguclu · 2023-06-19T17:32:47Z

/retest

ardaguclu · 2023-07-03T06:12:32Z

/retest

ardaguclu · 2023-07-03T09:43:23Z

/lgtm
/hold
until explain tests in origin is disabled temporarily

openshift-ci · 2023-07-03T09:44:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ardaguclu,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ardaguclu · 2023-07-04T14:38:59Z

/hold cancel
/retest

openshift-ci · 2023-07-04T19:48:31Z

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	`26507f3`	link	false	`/test e2e-metal-ipi-ovn-ipv6`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

atiratree changed the title ~~bump(k8s) to v0.27.1~~ WRKLDS-700: bump(k8s) to v0.27.1 May 9, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2023

openshift-ci bot requested review from mfojtik and soltysh May 9, 2023 19:01

atiratree commented May 9, 2023

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023

atiratree force-pushed the bump-k8s-1.27 branch from 09f2ace to 7665704 Compare May 10, 2023 11:14

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2023

atiratree force-pushed the bump-k8s-1.27 branch from 7665704 to 6ee58ae Compare May 11, 2023 22:18

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2023

atiratree mentioned this pull request May 11, 2023

introduce plugin and plugin shadowing tests for oc #1424

Merged

2 tasks

atiratree force-pushed the bump-k8s-1.27 branch from 6ee58ae to 58b20c1 Compare May 11, 2023 22:38

soltysh approved these changes May 22, 2023

View reviewed changes

openshift-ci bot assigned soltysh May 22, 2023

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 22, 2023

ardaguclu mentioned this pull request May 22, 2023

Change oc annotate cli test output check string openshift/origin#27932

Merged

atiratree mentioned this pull request May 24, 2023

fix oc explain status and spec verification openshift/origin#27937

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2023

flavianmissi mentioned this pull request Jun 16, 2023

wip: upgrade distribution #1428

Closed

atiratree force-pushed the bump-k8s-1.27 branch from 58b20c1 to bc6382d Compare June 19, 2023 11:38

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023

atiratree changed the title ~~WRKLDS-700: bump(k8s) to v0.27.1~~ WRKLDS-700: bump(k8s) to v0.27.2 Jun 19, 2023

atiratree added 2 commits June 19, 2023 13:42

bump(k8s) to v0.27.2

5d94ad3

go mod vendor

4eb0aab

atiratree force-pushed the bump-k8s-1.27 branch from bc6382d to 9d8407c Compare June 19, 2023 11:43

atiratree added 3 commits June 19, 2023 14:04

update makefile

08b03ab

react to changes in DeltaFIFO and CompGetResource

4918366

react to introduction of KUBECTL_ENABLE_CMD_SHADOW feature

26507f3

atiratree force-pushed the bump-k8s-1.27 branch from 9d8407c to 26507f3 Compare June 19, 2023 12:04

liouk mentioned this pull request Jun 21, 2023

AUTH-355: Add OAuth2 Authorization Code Grant Flow for login #1402

Merged

atiratree changed the title ~~WRKLDS-700: bump(k8s) to v0.27.2~~ WRKLDS-700: bump(k8s) to v1.27.2 Jun 29, 2023

openshift-ci bot assigned ardaguclu Jul 3, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2023

openshift-merge-robot merged commit 2fd1127 into openshift:master Jul 4, 2023
11 of 12 checks passed

atiratree mentioned this pull request Jul 4, 2023

upgrade distribution No 2 #1495

Merged

ardaguclu mentioned this pull request Jul 20, 2023

Add profiling functionality and flags in oc #1516

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WRKLDS-700: bump(k8s) to v1.27.2 #1420

WRKLDS-700: bump(k8s) to v1.27.2 #1420

atiratree commented May 9, 2023

openshift-ci-robot commented May 9, 2023 •

edited by openshift-ci bot

atiratree left a comment

atiratree May 9, 2023 •

edited

ardaguclu May 10, 2023

atiratree commented May 9, 2023

atiratree commented May 11, 2023

atiratree commented May 22, 2023

ardaguclu commented May 22, 2023

soltysh left a comment

ardaguclu commented May 22, 2023

ardaguclu commented May 24, 2023

atiratree commented May 24, 2023

atiratree commented May 25, 2023

ardaguclu commented Jun 7, 2023

flavianmissi commented Jun 16, 2023

atiratree commented Jun 19, 2023

atiratree commented Jun 19, 2023

ardaguclu commented Jun 19, 2023

ardaguclu commented Jul 3, 2023

ardaguclu commented Jul 3, 2023

openshift-ci bot commented Jul 3, 2023

ardaguclu commented Jul 4, 2023

openshift-ci bot commented Jul 4, 2023

WRKLDS-700: bump(k8s) to v1.27.2 #1420

WRKLDS-700: bump(k8s) to v1.27.2 #1420

Conversation

atiratree commented May 9, 2023

openshift-ci-robot commented May 9, 2023 • edited by openshift-ci bot

atiratree left a comment

Choose a reason for hiding this comment

atiratree May 9, 2023 • edited

Choose a reason for hiding this comment

ardaguclu May 10, 2023

Choose a reason for hiding this comment

atiratree commented May 9, 2023

atiratree commented May 11, 2023

atiratree commented May 22, 2023

ardaguclu commented May 22, 2023

soltysh left a comment

Choose a reason for hiding this comment

ardaguclu commented May 22, 2023

ardaguclu commented May 24, 2023

atiratree commented May 24, 2023

atiratree commented May 25, 2023

ardaguclu commented Jun 7, 2023

flavianmissi commented Jun 16, 2023

atiratree commented Jun 19, 2023

atiratree commented Jun 19, 2023

ardaguclu commented Jun 19, 2023

ardaguclu commented Jul 3, 2023

ardaguclu commented Jul 3, 2023

openshift-ci bot commented Jul 3, 2023

ardaguclu commented Jul 4, 2023

openshift-ci bot commented Jul 4, 2023

openshift-ci-robot commented May 9, 2023 •

edited by openshift-ci bot

atiratree May 9, 2023 •

edited