Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trt 1150 resource watch commit failures #28062

Closed

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jul 18, 2023

  • First commit moves the locking up so we don't write a file in the middle of another commit.

  • Second commit adds retry using git add . as a fallback in case we get in a bad state with multiple pending updates and no other way to recover.

@openshift-ci openshift-ci bot requested review from csrwng and spadgett July 18, 2023 16:40
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neisw
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 7abbbff link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-single-node-serial 7abbbff link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn 7abbbff link false /test e2e-metal-ipi-sdn
ci/prow/images 7abbbff link true /test images
ci/prow/e2e-aws-ovn-upgrade 7abbbff link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-rt-upgrade 7abbbff link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 7abbbff link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-serial 7abbbff link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 7abbbff link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd 7abbbff link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn 7abbbff link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 7abbbff link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-csi 7abbbff link false /test e2e-aws-csi
ci/prow/e2e-openstack-ovn 7abbbff link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-upgrade 7abbbff link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node 7abbbff link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi 7abbbff link false /test e2e-gcp-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@neisw
Copy link
Contributor Author

neisw commented Jul 18, 2023

/hold

additional review of the root issue.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neisw
Copy link
Contributor Author

neisw commented Jul 24, 2023

/close

@openshift-ci openshift-ci bot closed this Jul 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

@neisw: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants