Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trt-1150: move lock so prevent multiple file updates in single commit #28065

Merged
merged 4 commits into from Jul 22, 2023
Merged

trt-1150: move lock so prevent multiple file updates in single commit #28065

merged 4 commits into from Jul 22, 2023

Conversation

neisw
Copy link
Contributor

@neisw neisw commented Jul 18, 2023

Min version of 28062

  • Just pull in the moved lock for now. This will slow down commits, we want to evaluate these changes in isolation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 18, 2023 •
edited by openshift-ci bot

@neisw: This pull request references trt-1150 which is a valid jira issue.

In response to this:

Min version of 28062

  • Just pull in the moved lock for now. This will slow down commits, we want to evaluate these changes in isolation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bparees and spadgett July 18, 2023 20:38
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 80eaac0

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade High
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd High
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium

@DennisPeriquet
Copy link
Contributor

I don't see any observers-resource-watch in the presubmit artifacts (e.g., like this one)

@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61d5f720-2622-11ee-89d9-9b321c98b617-0

@DennisPeriquet
Copy link
Contributor

The resource-watch-store.tar with git status still shows:

On branch master
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   cluster-scoped-resources/config.openshift.io/apiservers/cluster.yaml
        modified:   cluster-scoped-resources/config.openshift.io/authentications/cluster.yaml
        modified:   cluster-scoped-resources/config.openshift.io/builds/cluster.yaml
        modified:   cluster-scoped-resources/config.openshift.io/clusteroperators/authentication.yaml
        modified:   cluster-scoped-resources/config.openshift.io/clusteroperators/baremetal.yaml
...

@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

/hold

needs more evaluation

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19bb3da0-2673-11ee-9521-3ea2977546fe-0

@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@neisw: aborted active payload jobs for pull request #28065

@neisw neisw force-pushed the trt-1150-resource-watch-handler-lock branch from f81fd55 to c53b9e6 Compare July 19, 2023 21:06
@neisw
Copy link
Contributor Author

neisw commented Jul 19, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/22a60260-2678-11ee-8f5f-c2d8a3a637a5-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023 •
edited

@neisw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial c53b9e6 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 c53b9e6 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-sdn c53b9e6 link false /test e2e-metal-ipi-sdn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: c53b9e6

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
pull-ci-openshift-origin-master-e2e-gcp-ovn Low

@neisw
Copy link
Contributor Author

neisw commented Jul 20, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30ed9a30-2732-11ee-9b26-3fae8dfc1056-0

@neisw
Copy link
Contributor Author

neisw commented Jul 20, 2023

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@neisw: aborted active payload jobs for pull request #28065

@neisw
Copy link
Contributor Author

neisw commented Jul 20, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@neisw: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea9281f0-2749-11ee-9ea5-c3cfc2752985-0

@deads2k
Copy link
Contributor

deads2k commented Jul 21, 2023

heck, why not. @neisw owns checking results and reverting if needed.'

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, neisw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@neisw
Copy link
Contributor Author

neisw commented Jul 21, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023
@neisw neisw mentioned this pull request Jul 21, 2023
Closed
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8ee28cd and 2 for PR HEAD 0bb45f8 in total

@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: 0bb45f8

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Medium
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 Medium
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd Medium

@openshift-merge-robot openshift-merge-robot merged commit a2002d8 into openshift:master Jul 22, 2023
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@neisw @openshift-ci-robot @openshift-trt-bot @DennisPeriquet @deads2k @openshift-merge-robot