Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-428: add PSa labelsyncer managed labels e2e tests #28257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AUTH-428: add PSa labelsyncer managed labels e2e tests #28257

wants to merge 1 commit into from

Conversation

liouk
Copy link
Member

@liouk liouk commented Sep 13, 2023

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 13, 2023 •
edited by openshift-ci bot
Loading

@liouk: This pull request references AUTH-428 which is a valid jira issue.

In response to this:

Adds e2e tests for the behavior added here:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liouk
Once this PR has been reviewed and has the lgtm label, please assign stlaz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liouk liouk force-pushed the psalabelsyncer-managed-labels branch 3 times, most recently from cb80df0 to 49d0add Compare September 13, 2023 14:56
@liouk liouk force-pushed the psalabelsyncer-managed-labels branch from 49d0add to 776c4bb Compare September 21, 2023 10:07
@liouk liouk changed the title WIP: AUTH-428: add PSa labelsyncer managed labels e2e tests AUTH-428: add PSa labelsyncer managed labels e2e tests Sep 21, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@liouk
Copy link
Member Author

liouk commented Sep 21, 2023

/retest

@liouk
Copy link
Member Author

liouk commented Sep 25, 2023

/retest-required

ibihim
ibihim suggested changes Oct 9, 2023
View reviewed changes
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated
}

func waitAndGetNamespace(ctx context.Context, oc *exutil.CLI, nsName string) (*corev1.Namespace, error) {
time.Sleep(2 * time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait until something happens is always better.

A hardcoded timelimit is always the worst case. It can also introduce a spiral of longer and longer test durations. If the cluster is slow, it will cause flakiness, which will then lead to an increase of the static sleep in all cases.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a generic polling function that waits for the namespace object to be updated by the labelsyncer after the original create/update, in 9418921.

I chose a generic equality condition, as what the labelsyncer is expected to do varies per test and test case (and in some cases no change is expected at all).

Copy link
Contributor

@ibihim ibihim Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A polling function is a great idea.

Test frameworks that offer a "wait" function are doing exactly that.

test/extended/authorization/podsecurity_admission.go Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
stlaz
stlaz suggested changes Oct 9, 2023
View reviewed changes
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Outdated Show resolved Hide resolved
test/extended/authorization/podsecurity_admission.go Show resolved Hide resolved
@liouk
Copy link
Member Author

liouk commented Oct 18, 2023 •
edited
Loading

added review fixes as fixups for clarity; will squash once reviewed
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2024
@liouk
Copy link
Member Author

liouk commented Jan 24, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2024
@liouk
Copy link
Member Author

liouk commented Jan 25, 2024

/retest

@liouk liouk force-pushed the psalabelsyncer-managed-labels branch from 9418921 to 2649633 Compare January 25, 2024 12:31
@liouk
Copy link
Member Author

liouk commented Jan 30, 2024

/retest

@liouk liouk force-pushed the psalabelsyncer-managed-labels branch from 2649633 to b0021c5 Compare January 31, 2024 10:34
@liouk
Copy link
Member Author

liouk commented Jan 31, 2024

/hold cancel
all fixups squashed

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@liouk
Copy link
Member Author

liouk commented Feb 8, 2024

/retest

@liouk
Copy link
Member Author

liouk commented Feb 8, 2024

/hold
test is failing

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@liouk liouk force-pushed the psalabelsyncer-managed-labels branch 3 times, most recently from 20e5af0 to 5486b12 Compare February 8, 2024 14:54
@liouk liouk force-pushed the psalabelsyncer-managed-labels branch from 5486b12 to ea0c6cd Compare February 9, 2024 10:12
@openshift-trt-bot
Copy link

Job Failure Risk Analysis for sha: ea0c6cd

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 96.00% of 25 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

Open Bugs
Auth operator capable of firing over 100 events in seconds on OpenShiftAPICheckFailed

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2024
@liouk
Copy link
Member Author

liouk commented Jun 4, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

@liouk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips ea0c6cd link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-cgroupsv2 ea0c6cd link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp-ovn ea0c6cd link true /test e2e-gcp-ovn
ci/prow/e2e-openstack-ovn ea0c6cd link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 ea0c6cd link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-upgrade ea0c6cd link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node ea0c6cd link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-serial ea0c6cd link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn ea0c6cd link false /test e2e-metal-ipi-sdn
ci/prow/e2e-gcp-ovn-builds ea0c6cd link true /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibihim ibihim ibihim requested changes

@stlaz stlaz stlaz requested changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@sosiouxme sosiouxme Awaiting requested review from sosiouxme

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liouk @openshift-ci-robot @openshift-bot @openshift-trt-bot @stlaz @ibihim