Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29028: Add function back to execute commands via pod #28621

Merged
merged 2 commits into from Mar 1, 2024
Merged

OCPBUGS-29028: Add function back to execute commands via pod #28621

merged 2 commits into from Mar 1, 2024

Conversation

Shilpa-Gokul
Copy link
Contributor

@Shilpa-Gokul Shilpa-Gokul commented Feb 27, 2024 •
edited

Fix for OCPBUGS-29028

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@Shilpa-Gokul Shilpa-Gokul changed the title [WIP] Add function back to execute commands via pod OCPBUGS-29028- Add function back to execute commands via pod Feb 27, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2024
@Shilpa-Gokul Shilpa-Gokul changed the title OCPBUGS-29028- Add function back to execute commands via pod OCPBUGS-29028: Add function back to execute commands via pod Feb 27, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2024
@openshift-ci-robot
Copy link

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-29028, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fix for OCPBUGS-29028

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2024
@openshift-ci-robot
Copy link

@Shilpa-Gokul: This pull request references Jira Issue OCPBUGS-29028, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Shilpa-Gokul
Copy link
Contributor Author

/retest-required

djslavens
djslavens approved these changes Feb 27, 2024
View reviewed changes
Copy link

@djslavens djslavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@tvardema
Copy link
Contributor

/lgtm

@jan--f
Copy link
Contributor

jan--f commented Feb 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ec17d7 and 2 for PR HEAD 759ae9c in total

simonpasquier
simonpasquier reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but you need to run make update-gofmt

test/extended/util/prometheus/helpers.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@Shilpa-Gokul
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djslavens, jan--f, Shilpa-Gokul, simonpasquier, tvardema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ec17d7 and 2 for PR HEAD 6e6699a in total

@simonpasquier
Copy link
Contributor

/retest-required

2 similar comments
@Shilpa-Gokul
Copy link
Contributor Author

/retest-required

@simonpasquier
Copy link
Contributor

/retest-required

@simonpasquier
Copy link
Contributor

/test e2e-aws-ovn-fips
/test e2e-gcp-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb34cbc and 1 for PR HEAD 6e6699a in total

@tvardema
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8696130 and 0 for PR HEAD 6e6699a in total

@openshift-ci-robot
Copy link

/hold

Revision 6e6699a was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@Shilpa-Gokul
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8696130 and 2 for PR HEAD 6e6699a in total

@Shilpa-Gokul
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024 •
edited

@Shilpa-Gokul: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 6e6699a link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-sdn 6e6699a link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 6e6699a link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 6e6699a link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-openstack-ovn 6e6699a link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 6e6699a link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link
Contributor

/test e2e-metal-ipi-ovn-ipv6

@openshift-merge-bot openshift-merge-bot bot merged commit e66eced into openshift:master Mar 1, 2024
17 of 23 checks passed
@openshift-ci-robot
Copy link

@Shilpa-Gokul: Jira Issue OCPBUGS-29028: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29028 has been moved to the MODIFIED state.

In response to this:

Fix for OCPBUGS-29028

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403012140.p0.ge66eced.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-03-05-105513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djslavens djslavens djslavens approved these changes

@jan--f jan--f Awaiting requested review from jan--f

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

@djslavens djslavens

@tvardema tvardema

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Shilpa-Gokul @openshift-ci-robot @tvardema @jan--f @simonpasquier @openshift-bot @openshift-merge-robot @djslavens