OCPBUGS-30604: fix panic on non-standard node-role labels

[stbenjam]

There was a second copy of the nodeRoles function that has the same problem, where non-standard format of the node-role label in ROSA causes a panic.

See 330feda.

I would refactor this to move the function to util and share it between both, but for backportability I fixed it in-place.

[openshift-ci-robot]

@stbenjam: This pull request references Jira Issue OCPBUGS-30604, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

There was a second copy of the nodeRoles function that has the same problem, where non-standard format of the node-role label in ROSA causes a panic.

See 330feda.

I would refactor this to move the function to util and share it between both, but for backportability I fixed it in-place.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stbenjam]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@stbenjam: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/jira refresh

[openshift-ci-robot]

@stbenjam: This pull request references Jira Issue OCPBUGS-30604, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stbenjam]

/jira refresh

[openshift-ci-robot]

@stbenjam: This pull request references Jira Issue OCPBUGS-30604, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dgoodwin]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgoodwin,stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 09489e4 and 2 for PR HEAD cc6882b in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 825c211 and 1 for PR HEAD cc6882b in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 6997884 and 0 for PR HEAD cc6882b in total

[openshift-ci]

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node-serial	cc6882b	link	false	/test e2e-aws-ovn-single-node-serial
ci/prow/e2e-metal-ipi-sdn	cc6882b	link	false	/test e2e-metal-ipi-sdn
ci/prow/e2e-gcp-ovn-rt-upgrade	cc6882b	link	false	/test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-upgrade	cc6882b	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-csi	cc6882b	link	false	/test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node	cc6882b	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/hold

Revision cc6882b was retested 3 times: holding

[openshift-trt-bot]

Job Failure Risk Analysis for sha: cc6882b

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (101) are below the historical average (977): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

[stbenjam]

/hold cancel
/retest-required

[openshift-ci-robot]

@stbenjam: Jira Issue OCPBUGS-30604: All pull requests linked via external trackers have merged:

• openshift/origin#28650

Jira Issue OCPBUGS-30604 has been moved to the MODIFIED state.

In response to this:

There was a second copy of the nodeRoles function that has the same problem, where non-standard format of the node-role label in ROSA causes a panic.

See 330feda.

I would refactor this to move the function to util and share it between both, but for backportability I fixed it in-place.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@stbenjam: new pull request created: #28656

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@stbenjam: #28650 failed to apply on top of branch "release-4.14":

Applying: OCPBUGS-30604: fix panic on non-standard node-role labels
Using index info to reconstruct a base tree...
M	pkg/monitortests/testframework/watchevents/event.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/monitortests/testframework/watchevents/event.go
CONFLICT (content): Merge conflict in pkg/monitortests/testframework/watchevents/event.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-30604: fix panic on non-standard node-role labels
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403141746.p0.gf2cc4d0.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.