Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-30892: fix panic on non-standard node-role labels #28656

Merged
merged 1 commit into from Mar 15, 2024
Merged

[release-4.15] OCPBUGS-30892: fix panic on non-standard node-role labels #28656

merged 1 commit into from Mar 15, 2024
+11 −4

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #28650

/assign stbenjam

@stbenjam
OCPBUGS-30604: fix panic on non-standard node-role labels
24d27d6 
There was a second copy of the nodeRoles function that has the same
problem, where non-standard format of the node-role label in ROSA causes
a panic.

See 330feda.

I would refactor this to move the function to util and share it between
both, but for backportability I fixed it in-place.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 13, 2024
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30604 has been cloned as Jira Issue OCPBUGS-30892. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-30892: fix panic on non-standard node-role labels

In response to this:

This is an automated cherry-pick of #28650

/assign stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-30604: fix panic on non-standard node-role labels [release-4.15] OCPBUGS-30892: fix panic on non-standard node-role labels Mar 13, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 13, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30892, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30604 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #28650

/assign stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and spadgett March 13, 2024 17:48
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 24d27d6 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node-serial 24d27d6 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 24d27d6 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

In an accepted 4.16 CI payload.

/jira refresh
/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2024
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-30892, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30604 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30604 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

In response to this:

In an accepted 4.16 CI payload.

/jira refresh
/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 15, 2024
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d68c509 and 2 for PR HEAD 24d27d6 in total

@openshift-merge-bot openshift-merge-bot bot merged commit f4b2b24 into openshift:release-4.15 Mar 15, 2024
20 of 23 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30892: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30892 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #28650

/assign stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.15.0-202403190408.p0.gf4b2b24.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@dgoodwin dgoodwin

@stbenjam stbenjam

@kasturinarra kasturinarra

@jadhaj jadhaj

@sunilcio sunilcio

@pamoedom pamoedom

@jitendar-singh jitendar-singh

@prietyc123 prietyc123

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet