-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EmptyDir volumes for new-app containers #3005
Conversation
[test] |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3088/) |
15e6d47
to
2fab0b4
Compare
Added & modified tests, thanks @Kargakis for help! PTAL |
template.Volumes = append(template.Volumes, kapi.Volume{ | ||
Name: v.Name, | ||
VolumeSource: kapi.VolumeSource{ | ||
EmptyDir: &kapi.EmptyDirVolumeSource{Medium: ""}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this constant here
This can go in after review and #3037 |
LGTM on green |
Evaluated for origin up to 4ca7271 |
Only assets test fails, unrelated to this PR. @smarterclayton your approval please? |
} else { | ||
srcType = "UNKNOWN" | ||
} | ||
got["volumes"] = append(got["volumes"], volume.Name+"♥"+srcType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unicode symbols can blow up user's editors. Let's avoid them in our codebase.
Closing in favour of #3098 since it encompasses this change and adds the warning. |
Modifies new-app so it defines volumes and volume mounts for containers based on volumes defined in docker images. Created volume sources are EmptyDir. Currently, the naming scheme is "containerName-volume-1".
For this to work and not break new-app with our images, #3037 must be merged first.
Example with json modified for brevity:
Fixes #2929