Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display standalone rcs #3698

Merged
merged 1 commit into from
Jul 15, 2015
Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 14, 2015

Makes oc status show standalone RCs. RCs that are not contained by a DC or covered by a Service.

In project example

service database - 172.30.17.240:5434 -> 3306
  rc/database-1 runs openshift/mysql-55-centos7
    rc/database-1 created 2 hours ago - 1 pod

rc/frontend-rc-1 runs openshift/ruby-hello-world
  rc/frontend-rc-1 created 2 hours ago - 3 pods

To see more, use 'oc describe service <name>' or 'oc describe dc <name>'.
You can use 'oc get all' to see a list of other objects.

@ironcladlou

@ironcladlou
Copy link
Contributor

Looks like you're missing test coverage for conflicting RCs. And some sort of rendering for them.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 14, 2015

Looks like you're missing test coverage for conflicting RCs. And some sort of rendering for them.

The code hadn't gotten that far yet because it's time to make a MarkerScanner to handle interesting conditions in the graph. This pull only includes displaying the standalone RCs with a pretty graphview object in front to handle the traversals.

@ironcladlou
Copy link
Contributor

Looks like you're missing test coverage for conflicting RCs. And some sort of rendering for them.

The code hadn't gotten that far yet because it's time to make a MarkerScanner to handle interesting conditions in the graph. This pull only includes displaying the standalone RCs with a pretty graphview object in front to handle the traversals.

Thanks. LGTM.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 14, 2015

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3629/) (Image: devenv-fedora_1998)

@deads2k
Copy link
Contributor Author

deads2k commented Jul 14, 2015

auth cache flake. re[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3629/)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 15bfee7

openshift-bot pushed a commit that referenced this pull request Jul 15, 2015
@openshift-bot openshift-bot merged commit 8a075a5 into openshift:master Jul 15, 2015
@deads2k deads2k deleted the show-standalone-rcs branch July 31, 2015 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants