Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Show older builds" link to browse builds #3812

Merged
merged 1 commit into from
Aug 4, 2015

Conversation

spadgett
Copy link
Member

Click to show older builds:

openshift_web_console

Builds appear in place after clicking:

openshift_web_console

Fixes #2979
See also #2146

@spadgett
Copy link
Member Author

@jwforres ptal

@jwforres
Copy link
Member

Can we make it so you can collapse it back?

This also makes me think we need some sort of visual history/trend summary on the build config. So the user knows if there were recently failures.

@spadgett
Copy link
Member Author

spadgett commented Aug 3, 2015

@jwforres Should we go ahead with the change and create follow-on issues for collapse behavior and trends?

I think we should be consistent with our "Show more" links in other places (show all templates, show older deployments, show older images). Right now they expand, but none of them collapse.

@jwforres
Copy link
Member

jwforres commented Aug 3, 2015

sure [merge]

@spadgett spadgett mentioned this pull request Aug 3, 2015
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2888/) (Image: devenv-fedora_2103)

@jwforres
Copy link
Member

jwforres commented Aug 4, 2015

unrelated failure [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to eb28538

openshift-bot pushed a commit that referenced this pull request Aug 4, 2015
@openshift-bot openshift-bot merged commit 786896f into openshift:master Aug 4, 2015
@spadgett spadgett deleted the collapse-builds branch August 25, 2015 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants