Always give new-app output a common label #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review..... :) |
| @@ -235,7 +235,7 @@ func setupAppConfig(f *clientcmd.Factory, c *cobra.Command, args []string, confi | |||
|
|
|||
| func setLabels(labels map[string]string, result *newcmd.AppResult) error { | |||
| if len(labels) == 0 { | |||
| return nil | |||
| labels = map[string]string{"app": result.Name} | |||
There was a problem hiding this comment.
should likely check when result.Name is empty... no pipelines got created because you were only instantiating templates.
|
Just one comment, other than that, looks good |
Only if no labels are specified - uses the first component name
smarterclayton
force-pushed
the
add_app_label
branch
from
2f66b7e
to
16f9790
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3779/) (Image: devenv-fedora_2050) |
|
Evaluated for origin up to 16f9790 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3779/) |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 24, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app= where name is --name or the first component's name.
@csrwng review please