add cli display coverage tests #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // MissingPrinterCoverageExceptions is the list of types that were missing printer methods when I started | ||
| // You should never add to this list | ||
| var MissingPrinterCoverageExceptions = []reflect.Type{ |
There was a problem hiding this comment.
Some of these may not seem like candidates, but remember that resource.Builder covers more types than just straight API server GETs.
deads2k
force-pushed
the
printer-coverage
branch
from
3c58829
to
6f74c5e
Compare
|
TODOs added. |
|
Thanks for this, LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2844/) (Image: devenv-fedora_2060) |
|
Evaluated for origin up to 6f74c5e |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 27, 2015
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever an API object is added, we should be adding describers and printers. If we choose not to, the choice should be made consciously. This forces people to think about it.
@fabianofranz ptal
When this is added to the merge queue, I'll open issues for adding printers and describers for missing objects.