Add attach, run, and annotate to cli #4299
Conversation
smarterclayton
force-pushed
the
upstream_commands
branch
from
778a2ff
to
4c45847
Compare
|
[test] |
|
LGTM |
|
I have one more commit to make run default to a DC with a fallback to creating an RC. |
|
Updated, ready for review |
smarterclayton
force-pushed
the
upstream_commands
branch
2 times, most recently
from
7c018b1
to
91fe6d4
Compare
| @@ -12,6 +12,13 @@ func init() { | |||
| } | |||
|
|
|||
| err := api.Scheme.AddDefaultingFuncs( | |||
| func(obj *DeploymentConfigSpec) { | |||
There was a problem hiding this comment.
I'm pretty sure this broke serialization tests. Why are defaulting this?
(Broke in the sense that you need to update them, not in the sense that we should never do this.)
There was a problem hiding this comment.
Because we should, going to put it in its own commit.
On Aug 21, 2015, at 8:30 AM, David Eads notifications@github.com wrote:
In pkg/deploy/api/v1/defaults.go
#4299 (comment):
@@ -12,6 +12,13 @@ func init() {
}err := api.Scheme.AddDefaultingFuncs(
func(obj *DeploymentConfigSpec) {
I'm pretty sure this broke serialization tests. Why are defaulting this?
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/origin/pull/4299/files#r37629330.
|
Hrm... kubectlcompattest didn't fail... |
smarterclayton
force-pushed
the
upstream_commands
branch
from
91fe6d4
to
c41e176
Compare
I didn't build the check the other way around because we add a lot of additional subcommands. |
|
I'm referring to the negative check of something that says it should be On Fri, Aug 21, 2015 at 9:21 AM, David Eads notifications@github.com
Clayton Coleman | Lead Engineer, OpenShift |
|
If nothing else I'm going to merge this..... |
|
lgtm |
|
[merge] |
|
[test] |
1 similar comment
|
[test] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3075/) (Image: devenv-fedora_2197) |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4439/) |
smarterclayton
force-pushed
the
upstream_commands
branch
2 times, most recently
from
b63a590
to
6eadf9b
Compare
Define "run/v1" as DeploymentConfig, and "run-controller/v1" as the upstream.
smarterclayton
force-pushed
the
upstream_commands
branch
from
6eadf9b
to
654eff6
Compare
|
Evaluated for origin merge up to 654eff6 |
|
Evaluated for origin test up to 654eff6 |
Merged by openshift-bot
Expose the commands to clients