Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the regex in hack/test-cmd.sh a little more flexible for downs… #4456

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

brenton
Copy link
Contributor

@brenton brenton commented Sep 1, 2015

…tream

Even though the build process is building them with 'origin' in the name
downstream has changed their default for --images to be non-origin.

@brenton
Copy link
Contributor Author

brenton commented Sep 1, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4700/)

@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2015

So the default behavior of oadm router is different depending on which repo built the binary? That seems a little odd. Do our other commands work like that? Is there an obvious way to predict its going to happen to you?

@brenton
Copy link
Contributor Author

brenton commented Sep 1, 2015

@deads2k, it's predictable in the since that if you have installed OpenShift Enterprise, Atomic Enterprise or Origin and you try to create the default router or registry it will match the environment.

This was changed during the Beta because admins would forget to pass in --images and they would end up installing the origin router or registry. That was a mess to deal with and explain.

@deads2k
Copy link
Contributor

deads2k commented Sep 1, 2015

Ok. Something is unhappy with your changes. I can't say as I see why its broken now, but it is. Take a look at jenkins

…tream

Even though the build process is building them with 'origin' in the name
downstream has changed their default for --images to be non-origin.
@brenton
Copy link
Contributor Author

brenton commented Sep 1, 2015

This change was something I used downstream a few weeks ago and realized I forgot to upstream it. Looks like my version wasn't setting the namespace like origin has been using recently.

@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2015

travis flaked on #4239

@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2015

jenkins flaked on #3624

@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2015

re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to ef9ba22

@brenton
Copy link
Contributor Author

brenton commented Sep 2, 2015

@deads2k, looks like jenkins is happy now. I don't think the travis failure is related. Could we merge this in?

@deads2k
Copy link
Contributor

deads2k commented Sep 2, 2015

TestRequestExecuteRemoteCommand again

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4700/) (Image: devenv-fedora_2266)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to ef9ba22

openshift-bot pushed a commit that referenced this pull request Sep 2, 2015
Merged by openshift-bot
@openshift-bot openshift-bot merged commit bfdb87a into openshift:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants