-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the regex in hack/test-cmd.sh a little more flexible for downs… #4456
Conversation
[test] |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4700/) |
So the default behavior of |
@deads2k, it's predictable in the since that if you have installed OpenShift Enterprise, Atomic Enterprise or Origin and you try to create the default router or registry it will match the environment. This was changed during the Beta because admins would forget to pass in |
Ok. Something is unhappy with your changes. I can't say as I see why its broken now, but it is. Take a look at jenkins |
…tream Even though the build process is building them with 'origin' in the name downstream has changed their default for --images to be non-origin.
This change was something I used downstream a few weeks ago and realized I forgot to upstream it. Looks like my version wasn't setting the namespace like origin has been using recently. |
travis flaked on #4239 |
jenkins flaked on #3624 |
re[test] |
Evaluated for origin test up to ef9ba22 |
@deads2k, looks like jenkins is happy now. I don't think the travis failure is related. Could we merge this in? |
TestRequestExecuteRemoteCommand again [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/4700/) (Image: devenv-fedora_2266) |
Evaluated for origin merge up to ef9ba22 |
…tream
Even though the build process is building them with 'origin' in the name
downstream has changed their default for --images to be non-origin.