Disable direct CLI invocation, shrink e2e tests #4771
Conversation
|
[test][extended:core] |
|
continuous-integration/openshift-jenkins/test Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5188/) |
|
@smarterclayton cool! this seems much better than building with CLI... it also means you need to have 'oc' binary when running the tests, but I think that is reasonable trade-off. I will review this tomorrow. |
smarterclayton
force-pushed
the
remove_direct_cli
branch
from
2f26ec3
to
9de3e36
Compare
|
[test][extended:core] |
smarterclayton
force-pushed
the
remove_direct_cli
branch
from
9de3e36
to
73fd5ff
Compare
| @@ -97,4 +97,4 @@ fi | |||
| echo "[INFO] Running extended tests" | |||
|
|
|||
| # Run the tests | |||
| TMPDIR=${BASETMPDIR} ginkgo -progress -stream -v -p "-skip=${SKIP}" "$@" ${OS_OUTPUT_BINPATH}/extended.test | |||
| TMPDIR=${BASETMPDIR} ginkgo -progress -stream -v "-skip=${SKIP}" "$@" ${OS_OUTPUT_BINPATH}/extended.test | |||
There was a problem hiding this comment.
does this mean we are no longer running parallel?
There was a problem hiding this comment.
Correct, for now. When I split the packages up I will run upstream non parallel, then us parallel
|
Couple small nits and questions but otherwise LGTM! |
|
@smarterclayton I will have to rework the start-build extended test for this :-) |
|
@mnagy tag :) |
smarterclayton
force-pushed
the
remove_direct_cli
branch
from
73fd5ff
to
d0e4a1c
Compare
|
[test] |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3397/) (Image: devenv-fedora_2403) |
Prevents e2e tests from having to build 50M of Go
smarterclayton
force-pushed
the
remove_direct_cli
branch
from
d0e4a1c
to
9a6a204
Compare
|
Evaluated for origin test up to 9a6a204 |
|
Evaluated for origin merge up to 9a6a204 |
Merged by openshift-bot
In preparation to move to a package based test model, make two changes:
The combined result shrinks the e2e package to around ~35M compiled which is 2-3x faster - that will enable us to move to a more idiomatic Ginkgo style where we execute packages directly.
Also disable parallelism as it was causing resource exhaustion issues (may reintroduce later).