Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show errors in name field until blurred #4856

Merged
merged 1 commit into from
Sep 30, 2015
Merged

Don't show errors in name field until blurred #4856

merged 1 commit into from
Sep 30, 2015

Conversation

spadgett
Copy link
Member

Check for $touched rather than $dirty, which is true only when the input loses focus.

Fixes #4828

@spadgett
Copy link
Member Author

@jwforres PTAL

@jwforres
Copy link
Member

If you don't change the value but tab through the field does $touched get set? Or does $touched only get set if the field is also $dirty?

@spadgett
Copy link
Member Author

If you tab out without changing the value, $touched is set.

@jwforres
Copy link
Member

So if you tab through a required field and don't set a value then its going to warn you that its required... yeah I guess that's ok.

@jwforres
Copy link
Member

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3432/) (Image: devenv-fedora_2427)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 700079a

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5253/)

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 700079a

openshift-bot pushed a commit that referenced this pull request Sep 30, 2015
Merge pull request #4856 from spadgett/name-validation
390d192 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 390d192 into openshift:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spadgett @jwforres @openshift-bot