Change validation timing on create from image page #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| links. Show the required error if the user enters and deletes the value, even if the field still | ||
| has focus. | ||
| --> | ||
| <div ng-class="{'has-error': (form.appname.$error.required && form.appname.$dirty) || (form.appname.$invalid && validateName) || nameTaken}"> |
There was a problem hiding this comment.
the meaning of validateName confused me at first because it reads as an action. maybe shouldValidateName ?
Avoid problems with the try it and more options links by changing when we validate fields.
spadgett
force-pushed
the
name-validation
branch
from
680f230
to
e574657
Compare
|
@jwforres updated from your comments |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3512/) (Image: devenv-fedora_2451) |
|
Evaluated for origin merge up to e574657 |
|
[Test]ing while waiting on the merge queue |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5445/) |
|
Evaluated for origin test up to e574657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid problems with the try it and more options links by changing when we validate fields.
Fixes #4912