Make image trigger test more reliable #5167
Conversation
This trigger test only expected a single update to the deploymentConfig during the test, which is not reliable. Refactor the test to be tolerant of multiple updates to the deploymentConfig.
|
[test] |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/5875/) |
|
Evaluated for origin test up to f652134 |
| break waitForNewConfig | ||
| // Multiple updates to the config can be expected (e.g. status | ||
| // updates), so wait for a significant update (e.g. version). | ||
| if newConfig.LatestVersion > 0 { |
There was a problem hiding this comment.
if we never see it, the test will just timeout, right? do we want to set a timeout on that earlier than the integration test timeout?
There was a problem hiding this comment.
The previous factoring also relied on watch or integration test timeouts, so it's no worse off. Makes sense to me to rely on the global timeout. Otherwise you have to choose arbitrary values or make config per test.
There was a problem hiding this comment.
ok. you still sweeping for other similar tests or ready to merge this one?
There was a problem hiding this comment.
Haven't found anything yet, will make followups as necessary. I'd like to knock this one out now.
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3660/) (Image: devenv-fedora_2484) |
|
Evaluated for origin merge up to f652134 |
Merged by openshift-bot
This trigger test only expected a single update to the deploymentConfig
during the test, which is not reliable. Refactor the test to be tolerant
of multiple updates to the deploymentConfig.
Fixes #5161