Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run deployer as non-root user #5802

Merged
merged 1 commit into from Nov 10, 2015
Merged

Run deployer as non-root user #5802

merged 1 commit into from Nov 10, 2015

Conversation

ironcladlou
Copy link
Contributor

Fixes #5769

@ironcladlou
Copy link
Contributor Author

cc @pweil-

liggitt
liggitt reviewed Nov 9, 2015
View reviewed changes
images/deployer/Dockerfile
@@ -9,4 +9,6 @@
#
FROM openshift/origin

USER 5555
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warrants a comment, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@pweil-
Copy link
Contributor

pweil- commented Nov 9, 2015

LGTM

[test]

This was referenced Nov 9, 2015
Merged
Closed
@smarterclayton
Copy link
Contributor

why did you pick 5555? If it's random, use 1001

@ironcladlou
Copy link
Contributor Author

why did you pick 5555? If it's random, use 1001

Completely arbitrary. I'll change this and the UID in #5805 to 1001.

@smarterclayton
Copy link
Contributor

This is approved if we rebuild, @danmcp due to it being a security issue.

@smarterclayton smarterclayton added this to the 1.1.0 milestone Nov 9, 2015
@smarterclayton
Copy link
Contributor

It is low risk

@ironcladlou
Copy link
Contributor Author

UID changed to 1001

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2015
@liggitt
Copy link
Contributor

liggitt commented Nov 10, 2015

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 378e96d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7013/)

@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3970/) (Image: devenv-rhel7_2668)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 378e96d

openshift-bot pushed a commit that referenced this pull request Nov 10, 2015
Merge pull request #5802 from ironcladlou/nonroot-deployer
74cb827 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 74cb827 into openshift:master Nov 10, 2015
@ironcladlou ironcladlou deleted the nonroot-deployer branch November 10, 2015 13:50
@sdodson
Copy link
Member

sdodson commented Nov 10, 2015

@tdawson if you happen to do the next OSE build we need to make sure that this change makes it into the ose image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ironcladlou @pweil- @smarterclayton @liggitt @openshift-bot @sdodson