Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update missing imagestream message to warning #6302

Merged
merged 1 commit into from Dec 15, 2015
Merged

update missing imagestream message to warning #6302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/deploy/graph/analysis/dc.go
View file
Open in desktop
Expand Up @@ -15,9 +15,9 @@ import (
)

const (
TagNotAvailableWarning = "ImageStreamTagNotAvailable"
MissingImageStreamErr = "MissingImageStream"
MissingImageStreamTagErr = "MissingImageStreamTag"
TagNotAvailableWarning = "ImageStreamTagNotAvailable"
MissingImageStreamErr = "MissingImageStream"
MissingImageStreamTagWarning = "MissingImageStreamTag"
)

// FindDeploymentConfigTriggerErrors checks for possible failures in deployment config
Expand Down Expand Up @@ -69,9 +69,9 @@ dc:
Node: uncastDcNode,
RelatedNodes: []graph.Node{uncastIstNode},

Severity: osgraph.ErrorSeverity,
Key: MissingImageStreamTagErr,
Message: fmt.Sprintf("The image trigger for %s will have no effect because %s does not exist.",
Severity: osgraph.WarningSeverity,
Key: MissingImageStreamTagWarning,
Message: fmt.Sprintf("The image trigger for %s will have no effect until %s is imported or created.",
dcNode.ResourceString(), istNode.ResourceString()),
})
continue dc
Expand Down
2 changes: 1 addition & 1 deletion pkg/deploy/graph/analysis/dc_test.go
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ func TestMissingImageStreamTag(t *testing.T) {
t.Fatalf("expected %v, got %v", e, a)
}

if got, expected := markers[0].Key, MissingImageStreamTagErr; got != expected {
if got, expected := markers[0].Key, MissingImageStreamTagWarning; got != expected {
t.Fatalf("expected marker key %q, got %q", expected, got)
}
}
Expand Down