Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update missing imagestream message to warning #6302

Merged
merged 1 commit into from Dec 15, 2015

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Dec 14, 2015

fixes #6281

@bparees
Copy link
Contributor Author

bparees commented Dec 14, 2015

@smarterclayton ptal, not exactly the message body you proposed.

@bparees
Copy link
Contributor Author

bparees commented Dec 14, 2015

[test]

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4335/) (Image: devenv-rhel7_2950)

@0xmichalis
Copy link
Contributor

Why is a missing image stream a warning and not an error?

@bparees
Copy link
Contributor Author

bparees commented Dec 14, 2015

@Kargakis hm. i lumped the two scenarios together, but perhaps you're right that a missing imagestream should be treated different from a missing imagestream tag. @smarterclayton ?

@smarterclayton
Copy link
Contributor

Missing image stream seems less common. We do support creating image
streams on push, but I think in this case having it be an error is probably
accurate given how we create things today.

On Mon, Dec 14, 2015 at 12:47 PM, Ben Parees notifications@github.com
wrote:

@Kargakis https://github.com/kargakis hm. i lumped the two scenarios
together, but perhaps you're right that a missing imagestream should be
treated different from a missing imagestream tag. @smarterclayton
https://github.com/smarterclayton ?


Reply to this email directly or view it on GitHub
#6302 (comment).

@bparees
Copy link
Contributor Author

bparees commented Dec 14, 2015

updated to only make missing IST an err, left missing IS alone.
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to cd655bb

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7804/)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to cd655bb

openshift-bot pushed a commit that referenced this pull request Dec 15, 2015
@openshift-bot openshift-bot merged commit 0136eda into openshift:master Dec 15, 2015
@bparees bparees deleted the error_message branch January 6, 2016 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image trigger error message is worded too strongly
4 participants