Template test is not reentrant #7078
Conversation
|
Evaluated for origin test up to 5710618 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/881/) |
| @@ -76,6 +79,9 @@ echo "template data precision: ok" | |||
|
|
|||
| os::cmd::expect_success 'oc create -f examples/sample-app/application-template-dockerbuild.json -n openshift' | |||
| os::cmd::expect_success 'oc policy add-role-to-user admin test-user' | |||
| new="$(mktemp -d)/tempconfig" | |||
| os::cmd::expect_success "oc config view --raw > $new" | |||
| export KUBECONFIG=$new | |||
There was a problem hiding this comment.
Looks like this is done to avoid trashing the shared kubeconfig file? I'd rather give each subscript its own copy in the test-cmd.sh script.
There was a problem hiding this comment.
Actually, that doesn't fix the reentrancy problem. It ruins your local script. So this is correct as is.
There was a problem hiding this comment.
how does copying the KUBECONFIG and invoking the tmp project creation and sub-script with KUBECONFIG=... break anything?
There was a problem hiding this comment.
Because the point of this change is to not require you to run hack/test-cmd.sh to test this. You just run test/cmd/templates.
|
The deletes lgtm, but I'd like to move the kubeconfig copy responsibility to the parent script. |
|
I'll do a follow up with a cleaner approach to both top and bottom level specialization of the user context. |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/881/) (Image: devenv-rhel7_3358) |
|
Evaluated for origin merge up to 5710618 |
[test]