-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restmapper #7154
Fix restmapper #7154
Conversation
431b42c
to
958a900
Compare
[test] |
nested = append(nested, strings.Join(splitStrings, "\n\t")) | ||
} | ||
|
||
return fmt.Sprintf("MultiRESTMapper{\n\t%s\n}", strings.Join(nested, "\n\t")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see it's just refactoring of old code. Nvmd
LGTM |
@Kargakis |
478157a
to
7a1bab2
Compare
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4919/) (Image: devenv-rhel7_3391) |
7a1bab2
to
13d062a
Compare
[merge] |
13d062a
to
b9776fd
Compare
Evaluated for origin test up to b9776fd |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1004/) |
Evaluated for origin merge up to b9776fd |
Merged by openshift-bot
Fixes #7090
The
MultiRESTMapper
didn't correctly combine errors and the shortcut expanding RESTMapper failed to override the required functions because it was anonymously including another RESTMapper.New message for missing resource: