Web console: log follow link visibility fix #7528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| </div> | |||
|
|
|||
|
|
|||
| <div class="row" ng-if="!chromeless"> | |||
| <div class="row" ng-if="(!chromeless)"> | |||
There was a problem hiding this comment.
I've gotten into the habit of parens in an ng-if when the var is !var to make it a little more explicit. The ! is easy to miss otherwise. Similar idea to (function() { })() vs function() {}();
|
[TEST] |
| if($scope.state !== 'logs') { | ||
| $scope.$evalAsync(function() { | ||
| $scope.state = 'logs'; | ||
| }); |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5073/) (Image: devenv-rhel7_3513) |
|
Ben asked to remove the merge tag so he can fix the indentation. |
…logViewer is pending
benjaminapetersen
force-pushed
the
bpeterse/issue-7478-log-link-load
branch
from
afc0edd
to
188b4b5
Compare
|
Evaluated for origin test up to 188b4b5 |
|
[merge] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1487/) |
|
Evaluated for origin merge up to 188b4b5 |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 23, 2016
…og-link-load Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spadgett @jwforres for review!
Fixes #7478